You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/23 06:28:56 UTC
[GitHub] [incubator-nuttx-apps] pkarashchenko opened a new pull request, #1378: Revert "Minor fixes"
pkarashchenko opened a new pull request, #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378
Reverts apache/incubator-nuttx-apps#1377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378#issuecomment-1288029247
@pkarashchenko why revert the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378#issuecomment-1288029512
> @pkarashchenko why revert the change?
I made a mistake in one commit and CI on mainline failed because of that. I did revert because will not have time till evening to fix the broken commit, so just to unblock others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378#issuecomment-1288034362
> > > @pkarashchenko why revert the change?
> >
> > I made a mistake in one commit and CI on mainline failed because of that. I did revert because will not have time till evening to fix the broken commit, so just to unblock others.
>
> which patch? I don't see your change can trigger `#include <array>` error.
https://github.com/apache/incubator-nuttx-apps/actions/runs/3304553082/jobs/5454071840#step:7:1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378#issuecomment-1288043615
Here is the fix for `#incude <array>`: https://github.com/apache/incubator-nuttx-apps/pull/1379, not your change @pkarashchenko .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378#issuecomment-1288030004
Let's try to fix compilation failure when GCC can't find `#include <array>`, so we can have reliable feedback from CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378#issuecomment-1288033284
> > @pkarashchenko why revert the change?
>
> I made a mistake in one commit and CI on mainline failed because of that. I did revert because will not have time till evening to fix the broken commit, so just to unblock others.
which patch? I don't see your change can trigger `#include <array>` error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1378: Revert "Minor fixes"
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1378:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1378#issuecomment-1288045703
> Here is the fix for `#incude <array>`: https://github.com/apache/incubator-nuttx-apps/pull/1379, not your change @pkarashchenko .
Yes. Thank you. My changes still have an issue that was not caught by CI due to array issue. I will resubmit my change later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org