You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/10/26 18:18:24 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

xiaoxiang781216 opened a new pull request #2128:
URL: https://github.com/apache/incubator-nuttx/pull/2128


   ## Summary
   To fix the issue: https://github.com/apache/incubator-nuttx/issues/2094
   
   ## Impact
   The automation build
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2128:
URL: https://github.com/apache/incubator-nuttx/pull/2128#discussion_r513201909



##########
File path: tools/testbuild.sh
##########
@@ -258,51 +258,55 @@ function build {
 function dotest {
   echo "===================================================================================="
   config=`echo $1 | cut -d',' -f1`
-  re="-${config/\//:}[[:space:]]"
-  if [[ "${blacklist} " =~ $re ]]; then
-    echo "Skipping: $1"
-  else
-    echo "Configuration/Tool: $1"
-    if [ ${PRINTLISTONLY} -eq 1 ]; then
+  check=-`uname -s`,${config/\//:}

Review comment:
       Done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2128:
URL: https://github.com/apache/incubator-nuttx/pull/2128#discussion_r512933207



##########
File path: tools/testbuild.sh
##########
@@ -258,51 +258,55 @@ function build {
 function dotest {
   echo "===================================================================================="
   config=`echo $1 | cut -d',' -f1`
-  re="-${config/\//:}[[:space:]]"
-  if [[ "${blacklist} " =~ $re ]]; then
-    echo "Skipping: $1"
-  else
-    echo "Configuration/Tool: $1"
-    if [ ${PRINTLISTONLY} -eq 1 ]; then
+  check=-`uname -s`,${config/\//:}

Review comment:
       When I was setting up the windows CI I did this to help ID the system. Maybe we should do the same here since uname is not always exact especially between 32/64bit. Then we also have and explicit list.
   
   ```
   kernel="$(uname -s)"
   case $kernel in
    Linux*) os=Linux;;
    Darwin*) os=Darwin;;
    CYGWIN*) os=Cygwin;;
    MINGW*) os=MinGw;;
    *) os="UNKNOWN:$kernel"
   esac
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton merged pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2128:
URL: https://github.com/apache/incubator-nuttx/pull/2128


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2128:
URL: https://github.com/apache/incubator-nuttx/pull/2128#issuecomment-716737626


   @xiaoxiang781216 did you look at my PR in testing?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2128: tools/testbuild.sh: Support the blacklist for the specific host

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2128:
URL: https://github.com/apache/incubator-nuttx/pull/2128#issuecomment-717433939


   @btashton I change black list to regex, it will help filter the config in the complex case regardless how we organize the black list(per host or per datalist). Please take a look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org