You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "gurpartap3697 (via GitHub)" <gi...@apache.org> on 2026/04/11 04:44:20 UTC
[PR] Fix flaky DurableSubInBrokerNetworkTest by replacing fixed sleeps with Wait.waitFor polling [activemq]
gurpartap3697 opened a new pull request, #1906:
URL: https://github.com/apache/activemq/pull/1906
### Description:
DurableSubInBrokerNetworkTest was intermittently failing in CI due to timing issues. `setUp()` started the `DiscoveryNetworkConnector` and immediately let tests run, with no guarantee the bridge was established.
After creating/removing durable subscriptions, the tests slept 100ms and then checked state with a single synchronous query. On slow or loaded CI machines, 100ms is insufficient for subscription changes to propagate across the broker network.
### Error:
```
Error: DurableSubInBrokerNetworkTest>CombinationTestSupport.runBare:113->CombinationTestSupport.runBare:107->testDurableSubNetwork:103
```
ref: https://github.com/apache/activemq/actions/runs/24242348177/job/70780252784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix flaky DurableSubInBrokerNetworkTest by replacing fixed sleeps with Wait.waitFor polling [activemq]
Posted by "gurpartap3697 (via GitHub)" <gi...@apache.org>.
gurpartap3697 commented on PR #1906:
URL: https://github.com/apache/activemq/pull/1906#issuecomment-4229741431
Thanks for the suggestion! I’ve updated the `Wait.waitFor()` calls to use a shorter polling interval.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix flaky DurableSubInBrokerNetworkTest by replacing fixed sleeps with Wait.waitFor polling [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #1906:
URL: https://github.com/apache/activemq/pull/1906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix flaky DurableSubInBrokerNetworkTest by replacing fixed sleeps with Wait.waitFor polling [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1906:
URL: https://github.com/apache/activemq/pull/1906#issuecomment-4238213278
Should be good if CI passes tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix flaky DurableSubInBrokerNetworkTest by replacing fixed sleeps with Wait.waitFor polling [activemq]
Posted by "cshannon (via GitHub)" <gi...@apache.org>.
cshannon commented on PR #1906:
URL: https://github.com/apache/activemq/pull/1906#issuecomment-4248171653
Tests keep failing (probably another flaky test) but going to try one more time anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact
Re: [PR] Fix flaky DurableSubInBrokerNetworkTest by replacing fixed sleeps with Wait.waitFor polling [activemq]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #1906:
URL: https://github.com/apache/activemq/pull/1906#issuecomment-4249248659
CI is failing on MQTT, so not on the DurableSubInBrokerNetworkTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For additional commands, e-mail: gitbox-help@activemq.apache.org
For further information, visit: https://activemq.apache.org/contact