[GitHub] [rocketmq-mqtt] YxAc commented on a diff in pull request #98: [ISSUE #97] fix wrong judg of toLmqMessage and add ut

[GitBox <gi...@apache.org>]

YxAc commented on code in PR #98:
URL: https://github.com/apache/rocketmq-mqtt/pull/98#discussion_r873169177


##########
mqtt-ds/src/test/java/org/apache/rocketmq/mqtt/ds/test/store/TestLmqQueueStoreManager.java:
##########
@@ -109,11 +133,79 @@ public void testPullMessage() throws MQBrokerException, RemotingException, Inter
         when(rebalanceImpl.getmQClientFactory()).thenReturn(mqClientInstance);
         MQClientAPIImpl mqClientAPI = mock(MQClientAPIImpl.class);
         when(mqClientInstance.getMQClientAPIImpl()).thenReturn(mqClientAPI);
-        when(mqClientInstance.findBrokerAddressInSubscribe(any(), anyLong(), anyBoolean())).thenReturn(new FindBrokerResult("test", false));
+        when(mqClientInstance.findBrokerAddressInSubscribe(any(), anyLong(), anyBoolean())).thenReturn(
+                new FindBrokerResult("test", false));
 
         lmqQueueStoreManager.pullMessage("test", new Queue(), new QueueOffset(), 1);
 
         verify(mqClientAPI).pullMessage(any(), any(), anyLong(), any(), any());
     }
 
+    @Test
+    public void testToLmqPullRequest() throws InvocationTargetException, NoSuchMethodException, IllegalAccessException {

Review Comment:
   test toLmqPullRequest included toLmqMessage



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org