You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by wr...@apache.org on 2010/02/04 19:50:05 UTC

svn commit: r906606 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_request.h modules/http/http_request.c

Author: wrowe
Date: Thu Feb  4 18:50:05 2010
New Revision: 906606

URL: http://svn.apache.org/viewvc?rev=906606&view=rev
Log:
Add ap_process_request_after_handler to the exported list for mod_serf

Modified:
    httpd/httpd/trunk/include/ap_mmn.h
    httpd/httpd/trunk/include/http_request.h
    httpd/httpd/trunk/modules/http/http_request.c

Modified: httpd/httpd/trunk/include/ap_mmn.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/ap_mmn.h?rev=906606&r1=906605&r2=906606&view=diff
==============================================================================
--- httpd/httpd/trunk/include/ap_mmn.h (original)
+++ httpd/httpd/trunk/include/ap_mmn.h Thu Feb  4 18:50:05 2010
@@ -213,6 +213,7 @@
  * 20091230.1 (2.3.5-dev)  add util_ldap_state_t.opTimeout
  * 20091230.2 (2.3.5-dev)  add ap_get_server_name_for_url()
  * 20091230.3 (2.3.6-dev)  add ap_parse_log_level()
+ * 20091230.4 (2.3.6-dev)  export ap_process_request_after_handler() for mod_serf
  *
  */
 
@@ -221,7 +222,7 @@
 #ifndef MODULE_MAGIC_NUMBER_MAJOR
 #define MODULE_MAGIC_NUMBER_MAJOR 20091230
 #endif
-#define MODULE_MAGIC_NUMBER_MINOR 3                     /* 0...n */
+#define MODULE_MAGIC_NUMBER_MINOR 4                     /* 0...n */
 
 /**
  * Determine if the server's current MODULE_MAGIC_NUMBER is at least a

Modified: httpd/httpd/trunk/include/http_request.h
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/include/http_request.h?rev=906606&r1=906605&r2=906606&view=diff
==============================================================================
--- httpd/httpd/trunk/include/http_request.h (original)
+++ httpd/httpd/trunk/include/http_request.h Thu Feb  4 18:50:05 2010
@@ -315,8 +315,10 @@
  */
 void ap_process_request(request_rec *r);
 
-/* For post-processing after a handler has finished with a request. (Commonly used after it was suspended) */
-void ap_process_request_after_handler(request_rec *r);
+/* For post-processing after a handler has finished with a request. 
+ * (Commonly used after it was suspended)
+ */
+AP_DECLARE(void) ap_process_request_after_handler(request_rec *r);
 
 /**
  * Process a top-level request from a client, allowing some or all of

Modified: httpd/httpd/trunk/modules/http/http_request.c
URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=906606&r1=906605&r2=906606&view=diff
==============================================================================
--- httpd/httpd/trunk/modules/http/http_request.c (original)
+++ httpd/httpd/trunk/modules/http/http_request.c Thu Feb  4 18:50:05 2010
@@ -237,7 +237,7 @@
 }
 
 
-void ap_process_request_after_handler(request_rec *r)
+AP_DECLARE(void) ap_process_request_after_handler(request_rec *r)
 {
     apr_bucket_brigade *bb;
     apr_bucket *b;



Re: svn commit: r906606 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_request.h modules/http/http_request.c

Posted by "William A. Rowe Jr." <wr...@rowe-clan.net>.
On 2/4/2010 3:34 PM, Guenter Knauf wrote:
> Bill,
> wrowe@apache.org schrieb:
>> Author: wrowe
>> Date: Thu Feb  4 18:50:05 2010
>> New Revision: 906606
>>
>> URL: http://svn.apache.org/viewvc?rev=906606&view=rev
>> Log:
>> Add ap_process_request_after_handler to the exported list for mod_serf
> see this thread:
> http://mail-archives.apache.org/mod_mbox/httpd-dev/200910.mbox/%3C4AC45F82.6010201@gmail.com%3E

Thanks Guenter,

I'm not offering a value judgment, I'm simply making trunk compile.  If folks
want to refactor to avoid exposing this API, I'm fine with that as well.  If
folks want to remove the offending modules, I'm fine with that, too.

That's why the commit message was absolutely explicit in its purpose, but I don't
have a preference and don't plan to revisit.

Re: svn commit: r906606 - in /httpd/httpd/trunk: include/ap_mmn.h include/http_request.h modules/http/http_request.c

Posted by Guenter Knauf <fu...@apache.org>.
Bill,
wrowe@apache.org schrieb:
> Author: wrowe
> Date: Thu Feb  4 18:50:05 2010
> New Revision: 906606
> 
> URL: http://svn.apache.org/viewvc?rev=906606&view=rev
> Log:
> Add ap_process_request_after_handler to the exported list for mod_serf
see this thread:
http://mail-archives.apache.org/mod_mbox/httpd-dev/200910.mbox/%3C4AC45F82.6010201@gmail.com%3E

Gün.