You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openoffice.apache.org by da...@apache.org on 2025/05/11 08:01:56 UTC

(openoffice) 12/18: Fix the test failures in XBreakIteratorTest._isBeginWord() and _isEndWord(). It was failing because the word type differed: it used WordType.ANY_WORD when calling XBreakIterator.isBeginWord() and XBreakIterator.isEndWord(), but used WordType.ANYWORD_IGNOREWHITESPACES instead when determining word boundaries to test in nextWord().

This is an automated email from the ASF dual-hosted git repository.

damjan pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/openoffice.git

commit 10a136b91c2b6359b8961d840270dd9f4203f77b
Author: Damjan Jovanovic <da...@apache.org>
AuthorDate: Fri May 9 03:28:39 2025 +0200

    Fix the test failures in XBreakIteratorTest._isBeginWord() and _isEndWord().
    It was failing because the word type differed: it used WordType.ANY_WORD
    when calling XBreakIterator.isBeginWord() and XBreakIterator.isEndWord(),
    but used WordType.ANYWORD_IGNOREWHITESPACES instead when determining
    word boundaries to test in nextWord().
    
    Patch by: me
---
 test/testuno/source/api/i18n/XBreakIteratorTest.java | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/test/testuno/source/api/i18n/XBreakIteratorTest.java b/test/testuno/source/api/i18n/XBreakIteratorTest.java
index 252793d006..cb8da5faaa 100644
--- a/test/testuno/source/api/i18n/XBreakIteratorTest.java
+++ b/test/testuno/source/api/i18n/XBreakIteratorTest.java
@@ -351,13 +351,11 @@ public class XBreakIteratorTest {
         for(int i = 0; i < vBounds.size(); i++) {
             Boundary iBounds = (Boundary)vBounds.get(i);
             boolean isBegin = oObj.isBeginWord(UnicodeString, iBounds.startPos,
-                                               locale, WordType.ANY_WORD);
+                                               locale, wordType);
             bRes = bRes && isBegin;
-            Assert.assertTrue("isBeginWord is wrong at position " + iBounds.startPos + ", string len " + UnicodeString.length(), isBegin);
             boolean isNotBegin = !oObj.isBeginWord(UnicodeString,
-                    iBounds.startPos + 1, locale, WordType.ANY_WORD);
+                    iBounds.startPos + 1, locale, wordType);
             bRes = bRes && isNotBegin;
-            Assert.assertTrue("isBeginWord is wrong at position " + (iBounds.startPos + 1) + " for bounds (" + iBounds.startPos + "," + iBounds.endPos, isNotBegin);
 
             System.out.println("At position + " + iBounds.startPos
                 + " isBeginWord? " + isBegin);
@@ -386,10 +384,10 @@ public class XBreakIteratorTest {
         for(int i = 0; i < vBounds.size(); i++) {
             Boundary iBounds = (Boundary)vBounds.get(i);
             boolean isEnd = oObj.isEndWord(UnicodeString, iBounds.endPos,
-                locale, WordType.ANY_WORD);
+                locale, wordType);
             bRes = bRes && isEnd;
             boolean isNotEnd = !oObj.isEndWord(UnicodeString,
-                iBounds.endPos - 1, locale, WordType.ANY_WORD);
+                iBounds.endPos - 1, locale, wordType);
             bRes = bRes && isNotEnd;
 
             System.out.println("At position + " + iBounds.endPos