[jira] [Commented] (WICKET-7123) Form.setDefaultButton() supports only one button per form hierarchy

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17912782#comment-17912782 ] 

ASF GitHub Bot commented on WICKET-7123:
----------------------------------------

theigl commented on PR #971:
URL: https://github.com/apache/wicket/pull/971#issuecomment-2589282917

   I just found quite a serious bug related to this PR: https://issues.apache.org/jira/browse/WICKET-7140. 
   
   @1azyman: Could you take a look at it?




> Form.setDefaultButton() supports only one button per form hierarchy
> -------------------------------------------------------------------
>
>                 Key: WICKET-7123
>                 URL: https://issues.apache.org/jira/browse/WICKET-7123
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-core
>    Affects Versions: 10.1.0
>            Reporter: Viliam Repan
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>             Fix For: 10.3.0
>
>
> Currently Form.setDefaultButton() support only one button per whole form hierarchy, which is a problem when there are multiple forms on page of for example popup. It complicates even further when those default submit buttons have custom visibility/enabled state.
> Current implementation puts hidden field in root form which stores name of submit button and then creates client JS click() via jquery.
> This should be easy doable directly on form where the default button is located without the need to pass it to root form.
> What do you think about this?
> PR available here https://github.com/apache/wicket/pull/968



--
This message was sent by Atlassian Jira
(v8.20.10#820010)