You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/07 01:46:55 UTC

[GitHub] [apisix-dashboard] imjoey opened a new pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

imjoey opened a new pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225


   Signed-off-by: imjoey <ma...@gmail.com>
   
   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   - [x] Backport patches
   
   - Related issues
   
   As the preparation for release v2.3, this PR is going to cherry-pick 50bcbe9 from master branch to v2.3 branch. Regarding to the details, please refer to #1212  .
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225#issuecomment-755833148


   @imjoey yes, that's because the actions only listen on the master branch 🤔 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225#issuecomment-755837654


   Could you please file a PR and listen on 2.x?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225#issuecomment-755838345


   > Could you please file a PR and listen on 2.x?
   
   @juzhiyuan sure, I will try. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225#issuecomment-755831588


   @juzhiyuan CI seems not triggered ? Commits backported also strongly needs CI verification. 😄 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225#issuecomment-755838515


   Great you are!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225#issuecomment-755835538


   > @imjoey yes, that's because the actions only listen on the master branch 🤔
   
   @juzhiyuan oh, this would lead us in danger. if we consider vX.Y as a stable release, IMHO vX.Y also needs CI, in case introducing additional bugs via bug hot fixes
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] imjoey commented on pull request #1225: feat: Improve consumer for i18n (#1212)(backport to v2.3)

Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1225:
URL: https://github.com/apache/apisix-dashboard/pull/1225#issuecomment-755830663


   @juzhiyuan @liuxiran this PR needs to be marked as `backport`. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org