You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "dimas-b (via GitHub)" <gi...@apache.org> on 2025/12/06 01:03:04 UTC
Re: [PR] [Core, Bug] CreateEntitiesIfNotExist/CreatePrincipal not return the same entity persisted. [polaris]
dimas-b commented on code in PR #3219:
URL: https://github.com/apache/polaris/pull/3219#discussion_r2594307744
##########
CHANGELOG.md:
##########
@@ -65,6 +65,7 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Added checksum to helm deployment so that it will restart when the configmap has changed.
- Generic Table is no longer in beta and is generally-available.
- Added Windows support for Python client
+- Ensure createEntitiesIfNotExist and createPrincipal return the entity actually persisted.
Review Comment:
IMHO, this fix does not affect Polaris end users, so it does not have to be mentioned in CHANGELOG (but it's ok to mention).
##########
CHANGELOG.md:
##########
@@ -65,6 +65,7 @@ request adding CHANGELOG notes for breaking (!) changes and possibly other secti
- Added checksum to helm deployment so that it will restart when the configmap has changed.
- Generic Table is no longer in beta and is generally-available.
- Added Windows support for Python client
+- Ensure createEntitiesIfNotExist and createPrincipal return the entity actually persisted.
Review Comment:
Is the fix is specific to `TransactionalMetaStoreManagerImpl` or applies to all implementations? (my impression is the former, but this message is generic) 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org