[GitHub] [druid] liran-funaro commented on a change in pull request #12250: Storing null-only columns in the segment

[GitBox <gi...@apache.org>]

liran-funaro commented on a change in pull request #12250:
URL: https://github.com/apache/druid/pull/12250#discussion_r803533406



##########
File path: processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java
##########
@@ -293,7 +294,7 @@ protected IncrementalIndex(
       timeAndMetricsColumnCapabilities.put(metricDesc.getName(), metricDesc.getCapabilities());
     }
 
-    DimensionsSpec dimensionsSpec = incrementalIndexSchema.getDimensionsSpec();
+    this.dimensionsSpec = incrementalIndexSchema.getDimensionsSpec();

Review comment:
       nit: This can be moved upwards with the rest of the field initializers.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org