You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by andreaTP <gi...@git.apache.org> on 2017/07/11 14:08:15 UTC
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
GitHub user andreaTP opened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is not available(i.e. behind corporate proxy).
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2766]
### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot=<alernative-url> -Dplugin.frontend.nodeDownloadRoot=<alernative-url> -Dplugin.frontend.yarnDownloadRoot=<alernative-url> -Dplugin.frontend.npmDownloadRoot=<alernative-url> -Dpypi.repo.url=<alernative-url> clean package
```
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin softCodeRepos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2483
----
commit faf8362e2e7b0ea308434c8c5fb96ae8cb07a1d2
Author: andrea <an...@gmail.com>
Date: 2017-07-11T13:55:01Z
Keep online resources configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2483
Sure. BTW, I couldn't find the Travis link. It seems that Github changed the URL in
Can I get the Travis build link for this PR?
Additionally,
> it is incredibly annoying for contributors to have to "baby-sit" Travis to get a green CI here :-S
Do you have any ideas for improving this situation? Any feedback or suggestion is welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is not available(i.e. behind corporate proxy).
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2766]
### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot=<alernative-url> -Dplugin.frontend.nodeDownloadRoot=<alernative-url> -Dplugin.frontend.yarnDownloadRoot=<alernative-url> -Dplugin.frontend.npmDownloadRoot=<alernative-url> -Dpypi.repo.url=<alernative-url> clean package
```
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin softCodeRepos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2483
----
commit 0aea864a99aa4adfdb210f8e67ed2da8aecb9bde
Author: andrea <an...@gmail.com>
Date: 2017-07-11T13:55:01Z
Keep online resources configurable
commit 1e5fd85f4ddd3d85985d2d9f39959071cd9ae115
Author: andrea <an...@gmail.com>
Date: 2017-07-14T09:54:13Z
remove deprecated downloadRoot
commit 647417c33f4b677f879b1ab4769a9f9db52d579a
Author: andrea <an...@gmail.com>
Date: 2017-07-14T10:46:49Z
fix typo
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is not available(i.e. behind corporate proxy).
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2766]
### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot=<alernative-url> -Dplugin.frontend.nodeDownloadRoot=<alernative-url> -Dplugin.frontend.yarnDownloadRoot=<alernative-url> -Dplugin.frontend.npmDownloadRoot=<alernative-url> -Dpypi.repo.url=<alernative-url> clean package
```
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin softCodeRepos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2483
----
commit faf8362e2e7b0ea308434c8c5fb96ae8cb07a1d2
Author: andrea <an...@gmail.com>
Date: 2017-07-11T13:55:01Z
Keep online resources configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
added a small section under the mentioned `Md` file @1ambda
please let me know if anything else is needed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is not available(i.e. behind corporate proxy).
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2766]
### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot=<alernative-url> -Dplugin.frontend.nodeDownloadRoot=<alernative-url> -Dplugin.frontend.yarnDownloadRoot=<alernative-url> -Dplugin.frontend.npmDownloadRoot=<alernative-url> -Dpypi.repo.url=<alernative-url> clean package
```
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin softCodeRepos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2483
----
commit 0aea864a99aa4adfdb210f8e67ed2da8aecb9bde
Author: andrea <an...@gmail.com>
Date: 2017-07-11T13:55:01Z
Keep online resources configurable
commit 1e5fd85f4ddd3d85985d2d9f39959071cd9ae115
Author: andrea <an...@gmail.com>
Date: 2017-07-14T09:54:13Z
remove deprecated downloadRoot
commit 647417c33f4b677f879b1ab4769a9f9db52d579a
Author: andrea <an...@gmail.com>
Date: 2017-07-14T10:46:49Z
fix typo
commit 6894bcd5b27b9b5a1294ce8bae47a3444a95b4a7
Author: andrea <an...@gmail.com>
Date: 2017-07-24T13:04:47Z
added docs for additional configurations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
yes, :-) done! @felixcheung
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
ping
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by imamura-kaicho <gi...@git.apache.org>.
Github user imamura-kaicho commented on the issue:
https://github.com/apache/zeppelin/pull/2483
Not an issue, but had challenge when using mvn build. Current pom has wagon plugin to download py4j.zip from pypi, but under proxy, it didn't work. I tried with this options to change url, but it also failed.
Finally, figured out my wagon plugin has problem when using proxy.
https://issues.apache.org/jira/browse/MNG-5237
I added following in pom.xml and resolved.
<build>
<extensions>
<extension>
<!-- this extension is required by wagon in order to pass the proxy -->
<groupId>org.apache.maven.wagon</groupId>
<artifactId>wagon-http-lightweight</artifactId>
<version>2.2</version>
</extension>
</extensions>
</build>
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
thanks! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2483
Can we write docs to let the user know they can set these options using maven profile?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
GitHub user andreaTP reopened a pull request:
https://github.com/apache/zeppelin/pull/2483
[ZEPPELIN-2766] Make online resources url configurable at compile time
### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is not available(i.e. behind corporate proxy).
### What type of PR is it?
[Improvement]
### What is the Jira issue?
[ZEPPELIN-2766]
### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot=<alernative-url> -Dplugin.frontend.nodeDownloadRoot=<alernative-url> -Dplugin.frontend.yarnDownloadRoot=<alernative-url> -Dplugin.frontend.npmDownloadRoot=<alernative-url> -Dpypi.repo.url=<alernative-url> clean package
```
### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nokia/zeppelin softCodeRepos
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2483
----
commit 08a25d8e4640d9f6bf06e78424ad5d6a4e4761af
Author: andrea <an...@gmail.com>
Date: 2017-07-11T13:55:01Z
Keep online resources configurable
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
should I do anything else to get this merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2483
CI passed https://travis-ci.org/nokia/zeppelin/builds/256876805
merge if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
I agree that this has got a really low priority, but could I kindly ask for review to keep this into master since it does not break anything and just add some added flexibility to the build?
Thanks a lot in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP closed the pull request at:
https://github.com/apache/zeppelin/pull/2483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
yes of course @felixcheung , basically I'm exposing through maven properties the ability for users to customize where to download from certain packets that are normally downloaded from very specific internet resources.
In this way one can build zeppelin from sources specifying faster or internal or more reliable addresses for those packages.
You can note that this does not break anything but just expose some plugin capabilities to users and fallback to proper default one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
rebased on top of master, removed a typo and removed `downloadRoot` parameter that turns out to be `deprecated`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2483
Is this enough place to describe build options? What do you think of?
- http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/setup/basics/how_to_build.html#build-command-examples
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
@1ambda haven't found any specific section in docs mentioning settings in maven profiles... could you point me to a section that could be improved with this additions?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
@1ambda
travis link:
https://travis-ci.org/nokia/zeppelin/builds/256876805
I think that tests are not really "stable", I mean, they are time and context dependent.
i.e. if one test doesn't clean properly it's execution env next test will fail
selenium tests should be splitted to use less time.
It will require time, sorry I do not have enough to contribute this fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...
Posted by andreaTP <gi...@git.apache.org>.
Github user andreaTP commented on the issue:
https://github.com/apache/zeppelin/pull/2483
B,T,W, it is incredibly annoying for contributors to have to "baby-sit" travis to get a green CI here :-S
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---