[GitHub] [doris] github-actions[bot] commented on a diff in pull request #16569: [Optimization](index) Optimization for no need to read raw data for index column that only in where clause

["github-actions[bot] (via GitHub)" <gi...@apache.org>]

github-actions[bot] commented on code in PR #16569:
URL: https://github.com/apache/doris/pull/16569#discussion_r1101185873


##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -51,6 +51,32 @@
 
 struct ColumnPredicateInfo {
     ColumnPredicateInfo() = default;
+
+    std::string debug_string() {
+        std::stringstream ss;
+        ss << "column_name=" << column_name << ", query_op=" << query_op
+           << ", query_value=" << query_value;
+        return ss.str();
+    }
+
+    bool is_empty() { return column_name.empty() && query_value.empty() && query_op.empty(); }

Review Comment:
   warning: method 'is_empty' can be made const [readability-make-member-function-const]
   
   ```suggestion
       bool is_empty() const { return column_name.empty() && query_value.empty() && query_op.empty(); }
   ```
   



##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -51,6 +51,32 @@ class ColumnIterator;
 
 struct ColumnPredicateInfo {
     ColumnPredicateInfo() = default;
+
+    std::string debug_string() {

Review Comment:
   warning: method 'debug_string' can be made const [readability-make-member-function-const]
   
   ```suggestion
       std::string debug_string() const {
   ```
   



##########
be/src/olap/rowset/segment_v2/segment_iterator.h:
##########
@@ -51,6 +51,32 @@
 
 struct ColumnPredicateInfo {
     ColumnPredicateInfo() = default;
+
+    std::string debug_string() {
+        std::stringstream ss;
+        ss << "column_name=" << column_name << ", query_op=" << query_op
+           << ", query_value=" << query_value;
+        return ss.str();
+    }
+
+    bool is_empty() { return column_name.empty() && query_value.empty() && query_op.empty(); }
+
+    bool is_equal(const ColumnPredicateInfo& column_pred_info) {

Review Comment:
   warning: method 'is_equal' can be made const [readability-make-member-function-const]
   
   ```suggestion
       bool is_equal(const ColumnPredicateInfo& column_pred_info) const {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org