You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/17 09:53:49 UTC
[GitHub] [servicecomb-kie] zhulijian1 opened a new pull request #96: Add go
secure check.
zhulijian1 opened a new pull request #96: Add go secure check.
URL: https://github.com/apache/servicecomb-kie/pull/96
Add go secure check for travis CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] zhulijian1 commented on a change in pull request
#96: #95 Add go secure check
Posted by GitBox <gi...@apache.org>.
zhulijian1 commented on a change in pull request #96: #95 Add go secure check
URL: https://github.com/apache/servicecomb-kie/pull/96#discussion_r380578394
##########
File path: server/handler/noop_auth_handler.go
##########
@@ -41,5 +42,7 @@ func (bk *NoopAuthHandler) Name() string {
return "auth-handler"
}
func init() {
- handler.RegisterHandler("auth-handler", newDomainResolver)
+ if err := handler.RegisterHandler("auth-handler", newDomainResolver); err != nil {
+ openlogging.Fatal("register auth-handler failed")
Review comment:
已修改
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #96: #95 Add go secure check
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #96: #95 Add go secure check
URL: https://github.com/apache/servicecomb-kie/pull/96#discussion_r380507960
##########
File path: server/config/struct.go
##########
@@ -36,4 +36,5 @@ type DB struct {
SSLEnabled bool `yaml:"sslEnabled"`
RootCA string `yaml:"rootCAFile"`
Timeout string `yaml:"timeout"`
+ VerifyPeer bool `yaml:"insecureSkipVerify"`
Review comment:
这个配置项太长了，改成verifyPeer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #96: #95 Add go secure check
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #96: #95 Add go secure check
URL: https://github.com/apache/servicecomb-kie/pull/96#discussion_r380508128
##########
File path: server/handler/noop_auth_handler.go
##########
@@ -41,5 +42,7 @@ func (bk *NoopAuthHandler) Name() string {
return "auth-handler"
}
func init() {
- handler.RegisterHandler("auth-handler", newDomainResolver)
+ if err := handler.RegisterHandler("auth-handler", newDomainResolver); err != nil {
+ openlogging.Fatal("register auth-handler failed")
Review comment:
要把err内容打出来
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] zhulijian1 commented on a change in pull request
#96: #95 Add go secure check
Posted by GitBox <gi...@apache.org>.
zhulijian1 commented on a change in pull request #96: #95 Add go secure check
URL: https://github.com/apache/servicecomb-kie/pull/96#discussion_r380578302
##########
File path: server/config/struct.go
##########
@@ -36,4 +36,5 @@ type DB struct {
SSLEnabled bool `yaml:"sslEnabled"`
RootCA string `yaml:"rootCAFile"`
Timeout string `yaml:"timeout"`
+ VerifyPeer bool `yaml:"insecureSkipVerify"`
Review comment:
已修改，已更新文档
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang commented on a change in pull
request #96: #95 Add go secure check
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #96: #95 Add go secure check
URL: https://github.com/apache/servicecomb-kie/pull/96#discussion_r380512083
##########
File path: server/config/struct.go
##########
@@ -36,4 +36,5 @@ type DB struct {
SSLEnabled bool `yaml:"sslEnabled"`
RootCA string `yaml:"rootCAFile"`
Timeout string `yaml:"timeout"`
+ VerifyPeer bool `yaml:"insecureSkipVerify"`
Review comment:
这个配置应当更新到文档中
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-kie] tianxiaoliang merged pull request #96: #95 Add go
secure check
Posted by GitBox <gi...@apache.org>.
tianxiaoliang merged pull request #96: #95 Add go secure check
URL: https://github.com/apache/servicecomb-kie/pull/96
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services