You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/26 15:13:33 UTC
[GitHub] [flink] akalash opened a new pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
akalash opened a new pull request #17573:
URL: https://github.com/apache/flink/pull/17573
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This PR forbid splitting the first record into two buffers if it physically fits one*
## Brief change log
- *Min buffer size is max between desirable buffer size and the first record size for both unicast and broadcast*
## Verifying this change
This change added tests and can be verified as follows:
- *Added new tests into ResultPartitionTest*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski merged pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
pnowojski merged pull request #17573:
URL: https://github.com/apache/flink/pull/17573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17573:
URL: https://github.com/apache/flink/pull/17573#discussion_r737626916
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -346,7 +346,8 @@ void announceBufferSize(int newBufferSize) {
@Override
int getBuffersInUseCount() {
- return subpartitionView.getNumberOfQueuedBuffers();
+ ResultSubpartitionView view = subpartitionView;
+ return view == null ? 0 : view.getNumberOfQueuedBuffers();
Review comment:
It is exactly what I wanted to ask - does it make sense or not to create a separate ticket for this.
But the point about the backport is the answer to it. so I will create the new ticket and move these changes into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17573:
URL: https://github.com/apache/flink/pull/17573#discussion_r738335950
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java
##########
@@ -270,20 +270,24 @@ private BufferBuilder appendUnicastDataForNewRecord(
}
private void addToSubpartition(
- BufferBuilder buffer, int targetSubpartition, int partialRecordLength)
+ BufferBuilder buffer,
+ int targetSubpartition,
+ int partialRecordLength,
+ int minAllowedBufferSize)
throws IOException {
int desirableBufferSize =
subpartitions[targetSubpartition].add(
buffer.createBufferConsumerFromBeginning(), partialRecordLength);
- resizeBuffer(buffer, desirableBufferSize);
+ resizeBuffer(buffer, desirableBufferSize, minAllowedBufferSize);
}
- private void resizeBuffer(BufferBuilder buffer, int desirableBufferSize) {
+ private void resizeBuffer(
+ BufferBuilder buffer, int desirableBufferSize, int minAllowedBufferSize) {
Review comment:
nit: rename `minAllowedBufferSize` -> `minDesirableBufferSize`? Or even better `remainingRecordSize`?
Almost for sure that's not min allowed size, as we are allowing for smaller buffer sizes, for example if recordSize > 32KB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952927633
(there are also some test failures)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952044174
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 0c03f9744353ae2b4140d334bc00649d311ee142 (Tue Oct 26 15:16:30 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] pnowojski commented on a change in pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
pnowojski commented on a change in pull request #17573:
URL: https://github.com/apache/flink/pull/17573#discussion_r737460618
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java
##########
@@ -327,12 +331,13 @@ private BufferBuilder appendBroadcastDataForRecordContinuation(
// with a complete record.
// !! The next two lines can not change order.
final int partialRecordBytes = buffer.appendAndCommit(remainingRecordBytes);
- createBroadcastBufferConsumers(buffer, partialRecordBytes);
+ createBroadcastBufferConsumers(buffer, partialRecordBytes, 0);
Review comment:
ditto
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java
##########
@@ -298,7 +302,7 @@ private BufferBuilder appendUnicastDataForRecordContinuation(
// with a complete record.
// !! The next two lines can not change order.
final int partialRecordBytes = buffer.appendAndCommit(remainingRecordBytes);
- addToSubpartition(buffer, targetSubpartition, partialRecordBytes);
+ addToSubpartition(buffer, targetSubpartition, partialRecordBytes, 0);
Review comment:
why not `addToSubpartition(buffer, targetSubpartition, partialRecordBytes, partialRecordBytes);`? (and if so add a test coverage)
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -346,7 +346,8 @@ void announceBufferSize(int newBufferSize) {
@Override
int getBuffersInUseCount() {
- return subpartitionView.getNumberOfQueuedBuffers();
+ ResultSubpartitionView view = subpartitionView;
+ return view == null ? 0 : view.getNumberOfQueuedBuffers();
Review comment:
1. is this change related to this ticket? How did you find this issue?
2. it sounds like this might deserve an independent bug ticket and might has to be backported to 1.14.x.
3. test coverage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17573:
URL: https://github.com/apache/flink/pull/17573#discussion_r737633413
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/LocalInputChannel.java
##########
@@ -346,7 +346,8 @@ void announceBufferSize(int newBufferSize) {
@Override
int getBuffersInUseCount() {
- return subpartitionView.getNumberOfQueuedBuffers();
+ ResultSubpartitionView view = subpartitionView;
+ return view == null ? 0 : view.getNumberOfQueuedBuffers();
Review comment:
https://issues.apache.org/jira/browse/FLINK-24671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17573:
URL: https://github.com/apache/flink/pull/17573#discussion_r737622601
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java
##########
@@ -327,12 +331,13 @@ private BufferBuilder appendBroadcastDataForRecordContinuation(
// with a complete record.
// !! The next two lines can not change order.
final int partialRecordBytes = buffer.appendAndCommit(remainingRecordBytes);
- createBroadcastBufferConsumers(buffer, partialRecordBytes);
+ createBroadcastBufferConsumers(buffer, partialRecordBytes, 0);
Review comment:
ditto :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
}, {
"hash" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560",
"triggerID" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"triggerType" : "PUSH"
}, {
"hash" : "ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25621",
"triggerID" : "ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e9f72686fe489c534ae8cf7ed71989485719e9f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560)
* ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25621)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
}, {
"hash" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560",
"triggerID" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"triggerType" : "PUSH"
}, {
"hash" : "ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e9f72686fe489c534ae8cf7ed71989485719e9f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560)
* ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
}, {
"hash" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560",
"triggerID" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3444ac297d6efb06fa2565e51fb64075aee43201 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536)
* e9f72686fe489c534ae8cf7ed71989485719e9f3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
akalash commented on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-953098679
I updated the commit in place. I just made changes in PartitionRequestQueueTest and replaced maxAllowedBUfferSize for partial record from 0 to partialRecordSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17573:
URL: https://github.com/apache/flink/pull/17573#discussion_r737621857
##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BufferWritingResultPartition.java
##########
@@ -298,7 +302,7 @@ private BufferBuilder appendUnicastDataForRecordContinuation(
// with a complete record.
// !! The next two lines can not change order.
final int partialRecordBytes = buffer.appendAndCommit(remainingRecordBytes);
- addToSubpartition(buffer, targetSubpartition, partialRecordBytes);
+ addToSubpartition(buffer, targetSubpartition, partialRecordBytes, 0);
Review comment:
in this case, it doesn't matter because both of them will work the same since we anyway never split the partial record. But as I can see now, perhaps you are right and `partialRecordBytes` looks more intuitive here
I have the test coverage for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
}, {
"hash" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560",
"triggerID" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"triggerType" : "PUSH"
}, {
"hash" : "ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25621",
"triggerID" : "ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ca6cfbe24c8a57c9ea33ebc8912d0607ad21f532 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25621)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
}, {
"hash" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3444ac297d6efb06fa2565e51fb64075aee43201 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536)
* e9f72686fe489c534ae8cf7ed71989485719e9f3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 0c03f9744353ae2b4140d334bc00649d311ee142 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476)
* 0413fd1ea88d920c106fa783b9e2061ce735228c Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532)
* 3444ac297d6efb06fa2565e51fb64075aee43201 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 3444ac297d6efb06fa2565e51fb64075aee43201 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17573: [FLINK-24190][runtime] Forbid to split the first record in the buffer if it physically fit it.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17573:
URL: https://github.com/apache/flink/pull/17573#issuecomment-952043255
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25476",
"triggerID" : "0c03f9744353ae2b4140d334bc00649d311ee142",
"triggerType" : "PUSH"
}, {
"hash" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25532",
"triggerID" : "0413fd1ea88d920c106fa783b9e2061ce735228c",
"triggerType" : "PUSH"
}, {
"hash" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25536",
"triggerID" : "3444ac297d6efb06fa2565e51fb64075aee43201",
"triggerType" : "PUSH"
}, {
"hash" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560",
"triggerID" : "e9f72686fe489c534ae8cf7ed71989485719e9f3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e9f72686fe489c534ae8cf7ed71989485719e9f3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25560)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org