[jira] [Commented] (CB-10894) Add supports-screens support from the config.xml file

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15478294#comment-15478294 ] 

ASF GitHub Bot commented on CB-10894:
-------------------------------------

Github user infil00p commented on the issue:

    https://github.com/apache/cordova-android/pull/280
  
    I'm going to close this PR with an empty commit.  The config-changes code added recently makes this change no longer needed, since you can just do this:
    
    `<edit-config file="AndroidManifest.xml" target="/manifest" mode="merge">
    <supports-screens android:resizeable=["true"| "false"]
                      android:smallScreens=["true" | "false"]
                      android:normalScreens=["true" | "false"]
                      android:largeScreens=["true" | "false"]
                      android:xlargeScreens=["true" | "false"]
                      android:anyDensity=["true" | "false"]
                      android:requiresSmallestWidthDp="integer"
                      android:compatibleWidthLimitDp="integer"
                      android:largestWidthLimitDp="integer"/>
    </edit-config>`
    



> Add supports-screens support from the config.xml file
> -----------------------------------------------------
>
>                 Key: CB-10894
>                 URL: https://issues.apache.org/jira/browse/CB-10894
>             Project: Apache Cordova
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Android
>            Reporter: Alexis Kofman
>            Assignee: Joe Bowser
>
> Let the availability to configure supported screens from the config.xml file :
> {code:xml}
> <preference name="android-smallScreens" value="false"/>
> <preference name="android-largeScreens" value="false"/>
> <preference name="android-normalScreens" value="false"/>
> <preference name="android-xlargeScreens" value="false"/>
> <preference name="android-resizeable" value="false"/>
> <preference name="android-anyDensity" value="false"/>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org