You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/09/26 17:53:30 UTC

[GitHub] TisonKun opened a new pull request #6768: [FLINK-10427] [tests] Port JobSubmitTest to new code base

TisonKun opened a new pull request #6768:  [FLINK-10427] [tests] Port JobSubmitTest to new code base
URL: https://github.com/apache/flink/pull/6768
 
 
   ## What is the purpose of the change
   
   Port `JobSubmitTest` to new code base
   
   ## Brief change log
   
   `JobSubmitTest` has three tests, here is their diagnosis:
   
   `testFailureWhenJarBlobsMissing` should be ported to `TaskTest#...`, FLIP-6 loads library on TM, not JM.
   
   To clarify, it is not applicable for FLIP-6 JM fail job because of failing to load library. So the porting job is active only when porting `TaskTest`. (Because the TaskTest is legacy test, too. we are unable to JUST add a test case onto that for now).
   
   `testFailureWhenInitializeOnMasterFails` is covered by `JobSubmissionFailsITCase#testExceptionInInitializeOnMaster`
   
   `testAnswerFailureWhenSavepointReadFails` is covered by `SavepointITCase#testSubmitWithUnknownSavepointPath`
   
   ## Verifying this change
   
   All about removal of tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (**no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
     - The serializers: (**no**)
     - The runtime per-record code paths (performance sensitive): (**no**)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (**no**)
     - The S3 file system connector: (**no**)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**no**)
     - If yes, how is the feature documented? (**no**)
   
   cc @tillrohrmann @GJL 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services