You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2025/11/04 03:42:44 UTC
[PR] [WIP](finish) Finish fragments once query finished [doris]
Gabriel39 opened a new pull request, #57667:
URL: https://github.com/apache/doris/pull/57667
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3484144567
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [thrift](finish) Finish fragments once query finished [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 closed pull request #57667: [thrift](finish) Finish fragments once query finished
URL: https://github.com/apache/doris/pull/57667
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3484040939
<details>
<summary>ClickBench: <b>Total hot run time: 28.26 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7f6b36507ce0d96f629024c9adeff9639f37c67f, data reload: false
query1 0.04 0.04 0.05
query2 0.12 0.07 0.06
query3 0.29 0.08 0.07
query4 1.61 0.10 0.09
query5 0.28 0.24 0.24
query6 1.17 0.65 0.64
query7 0.03 0.02 0.03
query8 0.07 0.06 0.05
query9 0.66 0.54 0.53
query10 0.59 0.59 0.58
query11 0.25 0.13 0.13
query12 0.25 0.14 0.15
query13 0.64 0.63 0.60
query14 1.03 1.03 1.03
query15 0.93 0.86 0.85
query16 0.40 0.38 0.38
query17 1.02 1.03 1.03
query18 0.23 0.22 0.23
query19 1.94 1.82 1.81
query20 0.02 0.02 0.01
query21 15.38 0.29 0.23
query22 4.99 0.10 0.09
query23 15.37 0.38 0.23
query24 2.82 0.50 0.32
query25 0.09 0.08 0.08
query26 0.19 0.18 0.18
query27 0.09 0.09 0.10
query28 3.67 1.26 1.09
query29 12.60 4.06 3.32
query30 0.35 0.12 0.12
query31 2.81 0.68 0.43
query32 3.24 0.59 0.50
query33 3.04 3.04 3.16
query34 16.49 5.20 4.50
query35 4.50 4.53 4.50
query36 0.65 0.52 0.50
query37 0.21 0.09 0.09
query38 0.18 0.05 0.06
query39 0.06 0.05 0.05
query40 0.20 0.18 0.17
query41 0.11 0.06 0.06
query42 0.07 0.04 0.05
query43 0.06 0.06 0.06
Total cold run time: 98.74 s
Total hot run time: 28.26 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3483635915
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3483638120
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3483682896
# Cloud UT Coverage Report
Increment line coverage ` ` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7f6b36507ce0d96f629024c9adeff9639f37c67f_7f6b36507ce0d96f629024c9adeff9639f37c67f_cloud/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7f6b36507ce0d96f629024c9adeff9639f37c67f_7f6b36507ce0d96f629024c9adeff9639f37c67f_cloud/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 80.71% (1674/2074) |
| Line Coverage | 67.05% (29556/44080) |
| Region Coverage | 67.61% (14707/21752) |
| Branch Coverage | 57.86% (7822/13520) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [thrift](finish) Finish fragments once query finished [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei commented on code in PR #57667:
URL: https://github.com/apache/doris/pull/57667#discussion_r2492540972
##########
gensrc/thrift/Status.thrift:
##########
@@ -109,6 +109,8 @@ enum TStatusCode {
OBTAIN_LOCK_FAILED = 74,
SNAPSHOT_EXPIRED = 75,
+ // Signal to finish fragments on BE by FE.
+ FINISH = 76,
Review Comment:
可以看看之前的名字,一般是使用的过去式
所以这里应该是FINISHED
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3484200816
# BE UT Coverage Report
Increment line coverage `100.00% (2/2)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/7f6b36507ce0d96f629024c9adeff9639f37c67f_7f6b36507ce0d96f629024c9adeff9639f37c67f/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/7f6b36507ce0d96f629024c9adeff9639f37c67f_7f6b36507ce0d96f629024c9adeff9639f37c67f/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 52.73% (18079/34287) |
| Line Coverage | 38.05% (164446/432240) |
| Region Coverage | 32.37% (125361/387269) |
| Branch Coverage | 33.80% (54889/162387) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3484031734
<details>
<summary>TPC-DS: <b>Total hot run time: 189581 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7f6b36507ce0d96f629024c9adeff9639f37c67f, data reload: false
query1 1062 415 389 389
query2 6552 1684 1716 1684
query3 6760 230 221 221
query4 26443 23589 23405 23405
query5 4896 621 456 456
query6 341 255 230 230
query7 4656 495 300 300
query8 334 280 248 248
query9 8738 2579 2550 2550
query10 553 347 291 291
query11 15857 15028 14757 14757
query12 197 122 115 115
query13 1713 558 449 449
query14 11208 9457 9181 9181
query15 199 195 177 177
query16 7690 695 530 530
query17 1531 776 628 628
query18 2070 509 374 374
query19 226 212 188 188
query20 137 134 123 123
query21 215 137 123 123
query22 4869 4751 4507 4507
query23 34787 33934 34066 33934
query24 8466 2582 2523 2523
query25 723 543 466 466
query26 1444 281 164 164
query27 2843 548 371 371
query28 4566 2239 2172 2172
query29 817 640 506 506
query30 349 228 206 206
query31 950 848 792 792
query32 84 75 66 66
query33 629 409 337 337
query34 829 1061 554 554
query35 845 895 809 809
query36 977 1002 941 941
query37 137 118 91 91
query38 3516 3615 3472 3472
query39 1442 1413 1417 1413
query40 211 127 117 117
query41 60 59 56 56
query42 120 114 108 108
query43 487 476 469 469
query44 1210 747 736 736
query45 187 180 177 177
query46 870 973 654 654
query47 1735 1761 1703 1703
query48 402 438 349 349
query49 798 517 433 433
query50 647 703 431 431
query51 3888 3890 3837 3837
query52 111 106 97 97
query53 232 267 193 193
query54 309 292 275 275
query55 86 83 86 83
query56 328 298 305 298
query57 1192 1217 1123 1123
query58 289 273 276 273
query59 2631 2683 2598 2598
query60 342 346 345 345
query61 167 162 162 162
query62 805 736 673 673
query63 242 194 196 194
query64 4506 1195 874 874
query65 4023 3924 3923 3923
query66 1083 428 331 331
query67 15533 15252 14810 14810
query68 8387 860 593 593
query69 500 318 296 296
query70 1328 1307 1286 1286
query71 437 333 371 333
query72 5862 4916 4951 4916
query73 647 568 361 361
query74 8854 8861 8909 8861
query75 3500 3390 2805 2805
query76 3430 1148 753 753
query77 560 402 314 314
query78 9504 9595 8929 8929
query79 2260 836 598 598
query80 633 569 512 512
query81 514 262 225 225
query82 208 156 134 134
query83 264 261 246 246
query84 260 112 96 96
query85 903 494 436 436
query86 380 329 307 307
query87 3714 3674 3661 3661
query88 3861 2258 2233 2233
query89 382 329 300 300
query90 2060 220 222 220
query91 161 165 138 138
query92 79 71 61 61
query93 1856 971 635 635
query94 687 431 340 340
query95 408 325 306 306
query96 486 574 283 283
query97 2914 2947 2851 2851
query98 252 212 209 209
query99 1340 1409 1278 1278
Total cold run time: 278776 ms
Total hot run time: 189581 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [WIP](finish) Finish fragments once query finished [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #57667:
URL: https://github.com/apache/doris/pull/57667#issuecomment-3484144484
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org