You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2023/06/05 09:46:29 UTC
[GitHub] [maven] gnodet opened a new pull request, #1148: [MNG-7805] Make the modelVersion optional when using build pom
gnodet opened a new pull request, #1148:
URL: https://github.com/apache/maven/pull/1148
JIRA issue: https://issues.apache.org/jira/browse/MNG-7805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] mthmulders commented on pull request #1148: [MNG-7805] Make the modelVersion optional when using build pom
Posted by "mthmulders (via GitHub)" <gi...@apache.org>.
mthmulders commented on PR #1148:
URL: https://github.com/apache/maven/pull/1148#issuecomment-1576562949
Maybe we should also add a test case that proves the `modelVersion` is kept intact if it's present in the input?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #1148: [MNG-7805] Make the modelVersion optional when using build pom
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1148:
URL: https://github.com/apache/maven/pull/1148#issuecomment-1592472126
> Maybe we can just drop consumer stuff, since as we proved, model can "move" with existing tech as well? Am just worried about gigantic projects and their heap requirements..
That's really not what the discussions on [dev@](https://lists.apache.org/thread/t0jj2mnwzxyd6oln3r67s78qvw4hdj4n) seem to lead to. The problem does not seem to be maven, but "other"(?) tools which we would not want to break by upgrading the model. So we'll have to forever produce a consumer pom, which means introducing a bom packaging (to differentiate between parent poms and consumed boms). However, I think we should flatten it, so that the used schema is minimal and it will also make things much faster in the long term when all dependencies are flattened.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet merged pull request #1148: [MNG-7805] Make the modelVersion optional when using build pom
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #1148:
URL: https://github.com/apache/maven/pull/1148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #1148: [MNG-7805] Make the modelVersion optional when using build pom
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #1148:
URL: https://github.com/apache/maven/pull/1148#issuecomment-1576484969
What about non-empty schema prefix? E..g, `xmlns:maven="..."`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #1148: [MNG-7805] Make the modelVersion optional when using build pom
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1148:
URL: https://github.com/apache/maven/pull/1148#issuecomment-1576507992
> What about non-empty schema prefix? E..g, `xmlns:maven="..."`?
I've added a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #1148: [MNG-7805] Make the modelVersion optional when using build pom
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #1148:
URL: https://github.com/apache/maven/pull/1148#issuecomment-1592453324
Maybe we can just drop consumer stuff, since as we proved, model can "move" with existing tech as well? Am just worried about gigantic projects and their heap requirements..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #1148: [MNG-7805] Make the modelVersion optional when using build pom
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #1148:
URL: https://github.com/apache/maven/pull/1148#issuecomment-1576587973
> Maybe we should also add a test case that proves the `modelVersion` is kept intact if it's present in the input?
Done, the two tests, now check the stability of the xml when `modelVersion` is already present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org