You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/09/17 00:30:43 UTC

[GitHub] [accumulo] ctubbsii opened a new pull request #1707: Simplify and clean up LogEntry

ctubbsii opened a new pull request #1707:
URL: https://github.com/apache/accumulo/pull/1707


   * Remove unused server parameter from the WAL LogEntry
   * Remove overloaded fromKeyValue method and rename to fromMetaWalEntry
   * Remove unused LogEntry copy constructor
   * Prevent extent inside LogEntry from leaving LogEntry by making it
     private, to ensure prevEndRow won't matter in any code outside the
     class, because log entries don't contain the prevEndRow information in
     the metadata tables
   * Deprecate LogEntry methods used only for upgrading the root table's
     WAL entries from previous versions (Upgrader9to10)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #1707: Simplify and clean up LogEntry

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1707:
URL: https://github.com/apache/accumulo/pull/1707#issuecomment-694415467


   Thanks for the review, @EdColeman ; I made a subsequent small change, if you want to take another look.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii merged pull request #1707: Simplify and clean up LogEntry

Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1707:
URL: https://github.com/apache/accumulo/pull/1707


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [accumulo] ctubbsii commented on pull request #1707: Simplify and clean up LogEntry

Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1707:
URL: https://github.com/apache/accumulo/pull/1707#issuecomment-693848838


   All ITs successfully passed with these changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org