You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by hu...@apache.org on 2021/05/27 21:44:12 UTC

[superset] branch pexdax/db-connection-ui-show-available updated: update on fetch

This is an automated email from the ASF dual-hosted git repository.

hugh pushed a commit to branch pexdax/db-connection-ui-show-available
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/pexdax/db-connection-ui-show-available by this push:
     new 37e8d57  update on fetch
37e8d57 is described below

commit 37e8d573d7be8808dae412090cf3e65c701a689b
Author: hughhhh <hu...@gmail.com>
AuthorDate: Thu May 27 17:40:56 2021 -0400

    update on fetch
---
 .../src/views/CRUD/data/database/DatabaseModal/index.tsx              | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
index 96da700..0576a48 100644
--- a/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
+++ b/superset-frontend/src/views/CRUD/data/database/DatabaseModal/index.tsx
@@ -329,10 +329,8 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
   useEffect(() => {
     if (isLoading) {
       setLoading(false);
-      console.log('done loading');
-      console.log(availableDbs);
     }
-  }, [availableDbs]);
+  }, [availableDbs, isLoading]);
 
   const tabChange = (key: string) => {
     setTabKey(key);