You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2016/03/09 01:38:23 UTC

Review Request 44541: SQOOP-2881: Sqoop2: EnrichOraOop Connector resource file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44541/
-----------------------------------------------------------

Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2881
    https://issues.apache.org/jira/browse/SQOOP-2881


Repository: sqoop-sqoop2


Description
-------

Please see parent JIRA for details.


Diffs
-----

  connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties d99ab9b 

Diff: https://reviews.apache.org/r/44541/diff/


Testing
-------


Thanks,

Jarek Cecho


Re: Review Request 44541: SQOOP-2881: Sqoop2: EnrichOraOop Connector resource file

Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44541/#review124610
-----------------------------------------------------------




connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties (line 23)
<https://reviews.apache.org/r/44541/#comment187222>

    i would replace "Oracle server" with "Oracle database"


- Abraham Fine


On March 9, 2016, 12:38 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44541/
> -----------------------------------------------------------
> 
> (Updated March 9, 2016, 12:38 a.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2881
>     https://issues.apache.org/jira/browse/SQOOP-2881
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Please see parent JIRA for details.
> 
> 
> Diffs
> -----
> 
>   connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties d99ab9b 
> 
> Diff: https://reviews.apache.org/r/44541/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 44541: SQOOP-2881: Sqoop2: EnrichOraOop Connector resource file

Posted by Abraham Fine <ab...@abrahamfine.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44541/#review124928
-----------------------------------------------------------


Ship it!




Ship It!

- Abraham Fine


On March 22, 2016, 8:37 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44541/
> -----------------------------------------------------------
> 
> (Updated March 22, 2016, 8:37 p.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2881
>     https://issues.apache.org/jira/browse/SQOOP-2881
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Please see parent JIRA for details.
> 
> 
> Diffs
> -----
> 
>   connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties d99ab9b 
> 
> Diff: https://reviews.apache.org/r/44541/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Re: Review Request 44541: SQOOP-2881: Sqoop2: EnrichOraOop Connector resource file

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44541/
-----------------------------------------------------------

(Updated March 22, 2016, 8:37 p.m.)


Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2881
    https://issues.apache.org/jira/browse/SQOOP-2881


Repository: sqoop-sqoop2


Description
-------

Please see parent JIRA for details.


Diffs (updated)
-----

  connector/connector-oracle-jdbc/src/main/resources/oracle-jdbc-connector-config.properties d99ab9b 

Diff: https://reviews.apache.org/r/44541/diff/


Testing
-------


Thanks,

Jarek Cecho