You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/01 12:18:54 UTC
[GitHub] [cloudstack-primate] Pearl1594 opened a new pull request #658: Fixes reload of page on session expiry
Pearl1594 opened a new pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685037795
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689313499
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/658 (JID-3444)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685048201
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/658 (JID-3415)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685560793
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-688158054
@Pearl1594 cc @davidjumani - is this ready for review/testing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685036996
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-692658515
Looks good to me:
-reduced session timeout to 1min, restarted mgmt
1. login, wait for 2minutes, go back to the same page, click on something, I get error that session has expired, redirected to the login screen - once I enter the login credentials - no more redirects/need to login again
2. login, wait for 2 minutes, do NOT click on anything, just refresh the page, I get the error that the session has expired, login once and then again all good (no more redirects / need to login again)
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-692617048
ping @borisstoyanov cc @andrijapanicsb can you review/test this, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689463260
@davidjumani are you LGTM on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689500268
Page still reloads after being pushed out, but without a significant delay. @borisstoyanov Could you test this fix ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685450339
Did a quick test LGTM (I deleted the jsession cookie and click a router-link), need more testing for cases (a) on mgmt server restart, (b) on actual session expiry (say after 30mins...) cc @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-688215588
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689308431
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-688780051
@davidjumani can you review as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd edited a comment on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
rhtyd edited a comment on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-685450339
Did a quick test LGTM (I deleted the jsession cookie and click a router-link), need more testing for cases (a) on mgmt server restart, (b) on actual session expiry (say after 30mins...) cc @davidjumani
However, after login it always goes to the /exception/403 page
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #658: Fixes reload of page on session expiry
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #658:
URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689308818
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org