You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "leaves12138 (via GitHub)" <gi...@apache.org> on 2023/11/13 09:32:13 UTC

[PR] [flink] [fix] Flink add computed column should be nullable [incubator-paimon]

leaves12138 opened a new pull request, #2307:
URL: https://github.com/apache/incubator-paimon/pull/2307

   
   
   ### Purpose
   
   
   sql "ALTER TABLE T add (__proc_time AS PROCTIME())" should be work well with paimon. And the clumn __proc_time which is ComputedColumn should be nullable.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [flink] [fix] Flink add computed column should be nullable [incubator-paimon]

Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2307:
URL: https://github.com/apache/incubator-paimon/pull/2307#issuecomment-1807993636

   > You should add test to use computed column and watermark for reading, a real ITCase.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [flink] [fix] Flink add computed column should be nullable [incubator-paimon]

Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #2307:
URL: https://github.com/apache/incubator-paimon/pull/2307#issuecomment-1809491288

   Already resolved in https://github.com/apache/incubator-paimon/pull/2297#pullrequestreview-1728717978


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [flink] [fix] Flink add computed column should be nullable [incubator-paimon]

Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 closed pull request #2307: [flink] [fix] Flink add computed column should be nullable
URL: https://github.com/apache/incubator-paimon/pull/2307


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [flink] [fix] Flink add computed column should be nullable [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #2307:
URL: https://github.com/apache/incubator-paimon/pull/2307#issuecomment-1808158839

   @leaves12138 Maybe you can just take a review to #2297, is that what you want?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [flink] [fix] Flink add computed column should be nullable [incubator-paimon]

Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on PR #2307:
URL: https://github.com/apache/incubator-paimon/pull/2307#issuecomment-1807879912

   You should add test to use computed column and watermark for reading.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org