You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@aries.apache.org by "Wolfgang Glas (JIRA)" <ji...@apache.org> on 2010/08/25 19:57:15 UTC
[jira] Created: (ARIES-389) Problem with type converters which
produce a null result.
Problem with type converters which produce a null result.
---------------------------------------------------------
Key: ARIES-389
URL: https://issues.apache.org/jira/browse/ARIES-389
Project: Aries
Issue Type: Bug
Components: Blueprint
Affects Versions: 0.1, 0.2, Incubation
Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
Reporter: Wolfgang Glas
In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
The type converter in necessary in order to correctly deal with unconfigured aka null values.
You may have a look at our open source library under
http://maven.clazzes.org/org/clazzes/util/0.9.1/
where the classes are contained in the package org.clazzes.util.osgi.
When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Wolfgang Glas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wolfgang Glas updated ARIES-389:
--------------------------------
Attachment: aries-blueprint-null-conversion-svn988025.patch
Patch which fixes the behaviout of AggregateConverter, when a type converter returns null.
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Attachments: aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Mahrwald reassigned ARIES-389:
---------------------------------------
Assignee: Valentin Mahrwald
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Assignee: Valentin Mahrwald
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Valentin Mahrwald resolved ARIES-389.
-------------------------------------
Resolution: Fixed
Thanks for the patch Wolfgang! I have committed it in revision 990789.
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Assignee: Valentin Mahrwald
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904185#action_12904185 ]
Valentin Mahrwald commented on ARIES-389:
-----------------------------------------
Hi Wolfgang,
judging by the time spans between inception, 0.1 and ongoing 0.2, I would expect this to be released sometime towards the end of this year or early next year in the 0.3 release. But that's really just a guess.
Regards, Valentin
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Assignee: Valentin Mahrwald
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Wolfgang Glas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Wolfgang Glas updated ARIES-389:
--------------------------------
Attachment: aries-blueprint-null-conversion-svn988025-r1.patch
Improved version of the patch with an included test case. The non-test portion of the test has not changed.
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Wolfgang Glas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904638#action_12904638 ]
Wolfgang Glas commented on ARIES-389:
-------------------------------------
Valentin,
Thanks for this information, I will keep an eye on the mailing list. If - for whatever reason - you need an RC6, I'd really love to have my patch merged, because I have to preapare a customized karaf package here in order to circumvent this issue.
Best regards, Wolfgang
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Assignee: Valentin Mahrwald
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Wolfgang Glas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904211#action_12904211 ]
Wolfgang Glas commented on ARIES-389:
-------------------------------------
Hmmm, so is there a chance to backport my fix to the 0.2 branch of aries?
I just tried
svn merge -r 990185:990789 https://svn.apache.org/repos/asf/incubator/aries/trunk
on the 0.2-incubating-RCx branch and the fix seems to fit perfectly ;-)
Doing so would be very benefitial for me.
Best regards, Wolfgang
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Assignee: Valentin Mahrwald
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Wolfgang Glas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904175#action_12904175 ]
Wolfgang Glas commented on ARIES-389:
-------------------------------------
Hi Valentin,
That's great news, thanks for applying the patch ;-)
Do you have a rough estimation, when this thing will trickle down into a released verion of aries?
Best regards, Wolfgang
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Assignee: Valentin Mahrwald
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ARIES-389) Problem with type converters which
produce a null result.
Posted by "Valentin Mahrwald (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ARIES-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904543#action_12904543 ]
Valentin Mahrwald commented on ARIES-389:
-----------------------------------------
Hi Wolfgang,
the 0.2 release is already in progress and on the fifth release candidate. At this stage I think - after talking this over with Zoe who does the release - we only really want to respin for show stopper defect.
That being said if you really need this, please feel free to comment (or vote -1) on the release discussion / vote thread and we will have the discussion there with everyone involved. Also, if there is another respin for any other reason, we'll try to get this in.
Regards,
Valentin
> Problem with type converters which produce a null result.
> ---------------------------------------------------------
>
> Key: ARIES-389
> URL: https://issues.apache.org/jira/browse/ARIES-389
> Project: Aries
> Issue Type: Bug
> Components: Blueprint
> Affects Versions: 0.1, 0.2, Incubation
> Environment: apache-karaf-2.0.0, running under jre-1.6 under Windows or Linux.
> Reporter: Wolfgang Glas
> Assignee: Valentin Mahrwald
> Attachments: aries-blueprint-null-conversion-svn988025-r1.patch, aries-blueprint-null-conversion-svn988025.patch
>
>
> In order to inject ConfigAdmin properties into blueprint beans we wrote a ConfigPropertyAccessor class, which produces ConfigProperty beans, which then may be injected into other bean's properties on behalf of a special type converter.
> The type converter in necessary in order to correctly deal with unconfigured aka null values.
> You may have a look at our open source library under
> http://maven.clazzes.org/org/clazzes/util/0.9.1/
> where the classes are contained in the package org.clazzes.util.osgi.
> When applying all this stuff on null config values in any aries blueprint version available to me at the time of writing, the null return value of the type converter has the effect, that the conversion algorithm in AggregateConverter.java continues with it's conversion machinery for all known types causing it to fail with an Exception.
> However in "OSGi Service Platform Release 4, Service Compendium 4.2" in section 121.9.3 on pages 689-690, there is no hint ,taht the conversion algorithm should continue after step 2, when a type converter has been selected in step 1.
> I will attach a fix, which fixes my problem for svn rev. 988025 on aries trunk.
> Please review my patch and let me know, whether I shoukld improve it or you are able to apply it to the aries trunk.
> Best regards, Wolfgang Glas
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.