You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "ayushi-agarwal (via GitHub)" <gi...@apache.org> on 2024/04/16 10:40:34 UTC
[PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
ayushi-agarwal opened a new pull request, #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424
## What changes were proposed in this pull request?
LZ4_RAW is currently not supported in velox, so fallback to non-native write when user specifies this compression codec.
(Partially Fixes: \#5341)
## How was this patch tested?
Ran UTs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2061138798
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5424_time.csv</font></td>
<td><font color=#000000>log/native_master_04_16_2024_33d183203_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>36.07</font></td>
<td><font color=#F92663>38.05</font></td>
<td><font color=#F92663>1.973</font></td>
<td><font color=#F92663>105.47%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>28.32</font></td>
<td><font color=#6F9915>24.39</font></td>
<td><font color=#6F9915>-3.930</font></td>
<td><font color=#6F9915>86.12%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>38.51</font></td>
<td><font color=#6F9915>37.50</font></td>
<td><font color=#6F9915>-1.011</font></td>
<td><font color=#6F9915>97.37%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q4</font></td>
<td><font color=#6F9915>41.14</font></td>
<td><font color=#6F9915>38.79</font></td>
<td><font color=#6F9915>-2.352</font></td>
<td><font color=#6F9915>94.28%</font></td>
</tr>
<tr>
<td><font color=#F92663>q5</font></td>
<td><font color=#F92663>69.30</font></td>
<td><font color=#F92663>70.62</font></td>
<td><font color=#F92663>1.325</font></td>
<td><font color=#F92663>101.91%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>6.95</font></td>
<td><font color=#F92663>9.68</font></td>
<td><font color=#F92663>2.727</font></td>
<td><font color=#F92663>139.22%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>86.12</font></td>
<td><font color=#6F9915>83.76</font></td>
<td><font color=#6F9915>-2.360</font></td>
<td><font color=#6F9915>97.26%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>84.42</font></td>
<td><font color=#F92663>86.47</font></td>
<td><font color=#F92663>2.052</font></td>
<td><font color=#F92663>102.43%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>124.35</font></td>
<td><font color=#6F9915>124.25</font></td>
<td><font color=#6F9915>-0.098</font></td>
<td><font color=#6F9915>99.92%</font></td>
</tr>
<tr>
<td><font color=#F92663>q10</font></td>
<td><font color=#F92663>44.56</font></td>
<td><font color=#F92663>47.10</font></td>
<td><font color=#F92663>2.541</font></td>
<td><font color=#F92663>105.70%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q11</font></td>
<td><font color=#6F9915>20.63</font></td>
<td><font color=#6F9915>20.01</font></td>
<td><font color=#6F9915>-0.618</font></td>
<td><font color=#6F9915>97.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>26.40</font></td>
<td><font color=#F92663>30.02</font></td>
<td><font color=#F92663>3.619</font></td>
<td><font color=#F92663>113.71%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q13</font></td>
<td><font color=#6F9915>55.10</font></td>
<td><font color=#6F9915>53.95</font></td>
<td><font color=#6F9915>-1.147</font></td>
<td><font color=#6F9915>97.92%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>18.93</font></td>
<td><font color=#6F9915>17.11</font></td>
<td><font color=#6F9915>-1.815</font></td>
<td><font color=#6F9915>90.41%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>29.43</font></td>
<td><font color=#6F9915>29.43</font></td>
<td><font color=#6F9915>-0.000</font></td>
<td><font color=#6F9915>100.00%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>13.83</font></td>
<td><font color=#F92663>13.85</font></td>
<td><font color=#F92663>0.016</font></td>
<td><font color=#F92663>100.12%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>103.15</font></td>
<td><font color=#6F9915>101.18</font></td>
<td><font color=#6F9915>-1.967</font></td>
<td><font color=#6F9915>98.09%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>144.02</font></td>
<td><font color=#F92663>144.50</font></td>
<td><font color=#F92663>0.477</font></td>
<td><font color=#F92663>100.33%</font></td>
</tr>
<tr>
<td><font color=#F92663>q19</font></td>
<td><font color=#F92663>13.57</font></td>
<td><font color=#F92663>16.75</font></td>
<td><font color=#F92663>3.175</font></td>
<td><font color=#F92663>123.39%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>27.72</font></td>
<td><font color=#6F9915>26.88</font></td>
<td><font color=#6F9915>-0.843</font></td>
<td><font color=#6F9915>96.96%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>290.26</font></td>
<td><font color=#6F9915>287.81</font></td>
<td><font color=#6F9915>-2.456</font></td>
<td><font color=#6F9915>99.15%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>14.57</font></td>
<td><font color=#F92663>16.10</font></td>
<td><font color=#F92663>1.525</font></td>
<td><font color=#F92663>110.47%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1317.36</font></td>
<td><font color=#F92663>1318.19</font></td>
<td><font color=#F92663>0.833</font></td>
<td><font color=#F92663>100.06%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "ayushi-agarwal (via GitHub)" <gi...@apache.org>.
ayushi-agarwal commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059825557
The tests won't pass till issue https://github.com/apache/incubator-gluten/issues/5427 gets fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "zhli1142015 (via GitHub)" <gi...@apache.org>.
zhli1142015 merged PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059829472
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059095567
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2058781590
https://github.com/apache/incubator-gluten/issues/5341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2059843337
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "ayushi-agarwal (via GitHub)" <gi...@apache.org>.
ayushi-agarwal commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2058804683
@JkSelf Could you please review this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "ayushi-agarwal (via GitHub)" <gi...@apache.org>.
ayushi-agarwal commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2061052715
@JkSelf @Yohahaha Thanks for reviewing. Could you please merge it if everything looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5424:
URL: https://github.com/apache/incubator-gluten/pull/5424#issuecomment-2058782640
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5341]Fix test write parquet with compression codec [incubator-gluten]
Posted by "ayushi-agarwal (via GitHub)" <gi...@apache.org>.
ayushi-agarwal closed pull request #5424: [GLUTEN-5341]Fix test write parquet with compression codec
URL: https://github.com/apache/incubator-gluten/pull/5424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org