You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/01/17 15:15:40 UTC

Review Request 65190: Updated comments in io switchboard.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65190/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov and Kevin Klues.


Bugs: MESOS-7742
    https://issues.apache.org/jira/browse/MESOS-7742


Repository: mesos


Description
-------

This is addendum to review https://reviews.apache.org/r/65122


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp a1a50ce5671685012d015845c2f6d07749e393eb 


Diff: https://reviews.apache.org/r/65190/diff/1/


Testing
-------

None: not a functional change.


Thanks,

Andrei Budnik


Re: Review Request 65190: Updated comments in io switchboard.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65190/#review195607
-----------------------------------------------------------



PASS: Mesos patch 65190 was successfully built and tested.

Reviews applied: `['65190']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65190

- Mesos Reviewbot Windows


On Jan. 17, 2018, 4:11 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65190/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 4:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
>     https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is addendum to review https://reviews.apache.org/r/65122
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp a1a50ce5671685012d015845c2f6d07749e393eb 
> 
> 
> Diff: https://reviews.apache.org/r/65190/diff/1/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Re: Review Request 65190: Updated comments in io switchboard.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65190/#review195612
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 17, 2018, 4:11 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65190/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 4:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
>     https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is addendum to review https://reviews.apache.org/r/65122
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp a1a50ce5671685012d015845c2f6d07749e393eb 
> 
> 
> Diff: https://reviews.apache.org/r/65190/diff/1/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Re: Review Request 65190: Updated comments in io switchboard.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65190/#review195610
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Jan. 17, 2018, 4:11 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65190/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2018, 4:11 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Kevin Klues.
> 
> 
> Bugs: MESOS-7742
>     https://issues.apache.org/jira/browse/MESOS-7742
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is addendum to review https://reviews.apache.org/r/65122
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/io/switchboard.cpp a1a50ce5671685012d015845c2f6d07749e393eb 
> 
> 
> Diff: https://reviews.apache.org/r/65190/diff/1/
> 
> 
> Testing
> -------
> 
> None: not a functional change.
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Re: Review Request 65190: Updated comments in io switchboard.

Posted by Andrei Budnik <ab...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65190/
-----------------------------------------------------------

(Updated Jan. 17, 2018, 4:11 p.m.)


Review request for mesos, Alexander Rukletsov and Kevin Klues.


Bugs: MESOS-7742
    https://issues.apache.org/jira/browse/MESOS-7742


Repository: mesos


Description
-------

This is addendum to review https://reviews.apache.org/r/65122


Diffs
-----

  src/slave/containerizer/mesos/io/switchboard.cpp a1a50ce5671685012d015845c2f6d07749e393eb 


Diff: https://reviews.apache.org/r/65190/diff/1/


Testing
-------

None: not a functional change.


Thanks,

Andrei Budnik