[GitHub] [incubator-doris] wangbo commented on a diff in pull request #9065: [fix](storage) Disable compaction before schema change is actually executed(#9032)

[GitBox <gi...@apache.org>]

wangbo commented on code in PR #9065:
URL: https://github.com/apache/incubator-doris/pull/9065#discussion_r852603897


##########
be/src/olap/compaction.cpp:
##########
@@ -174,13 +174,17 @@ Status Compaction::construct_input_rowset_readers() {
     return Status::OK();
 }
 
-void Compaction::modify_rowsets() {
+Status Compaction::modify_rowsets() {
     std::vector<RowsetSharedPtr> output_rowsets;
     output_rowsets.push_back(_output_rowset);
-
     std::lock_guard<std::shared_mutex> wrlock(_tablet->get_header_lock());
-    _tablet->modify_rowsets(output_rowsets, _input_rowsets);
-    _tablet->save_meta();
+    if (_tablet->modify_rowsets(output_rowsets, _input_rowsets, true)) {
+        _tablet->save_meta();
+        return Status::OK();
+    } else {
+        return Status::OLAPInternalError(OLAP_ERR_DELETE_VERSION_ERROR)
+        return ;

Review Comment:
   duplicate return here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org