You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2017/07/11 16:53:39 UTC

[kudu-CR](gh-pages) Add a note in the YCSB post

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/7396

to review the following change.

Change subject: Add a note in the YCSB post
......................................................................

Add a note in the YCSB post

Last year we posted results in a blog post and recommended users
try some configurations related to flushing. We then changed the
defauls in the next version, but we still see instances of users
taking that post as gospel.

Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
---
M _posts/2016-04-26-ycsb.md
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/7396/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR](gh-pages) Add a note in the YCSB post

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Add a note in the YCSB post
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7396/1/_posts/2016-04-26-ycsb.md
File _posts/2016-04-26-ycsb.md:

PS1, Line 369: changing their value isn't warranted
"changing their value" is not clear. Maybe something like:

As of Kudu 0.10.0, the default configuration was changed based on the results of the above exploration. We recommend against modifying these configuration variables in Kudu 1.0 or later.


-- 
To view, visit http://gerrit.cloudera.org:8080/7396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add a note in the YCSB post

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has uploaded a new patch set (#2).

Change subject: Add a note in the YCSB post
......................................................................

Add a note in the YCSB post

Last year we posted results in a blog post and recommended users
try some configurations related to flushing. We then changed the
defaults in the next version, but we still see instances of users
taking that post as gospel.

Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
---
M _posts/2016-04-26-ycsb.md
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/96/7396/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>

[kudu-CR](gh-pages) Add a note in the YCSB post

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.

Change subject: Add a note in the YCSB post
......................................................................


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/7396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add a note in the YCSB post

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Add a note in the YCSB post
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7396/1/_posts/2016-04-26-ycsb.md
File _posts/2016-04-26-ycsb.md:

PS1, Line 369: changing their value isn't warranted
> "changing their value" is not clear. Maybe something like:
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes

[kudu-CR](gh-pages) Add a note in the YCSB post

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.

Change subject: Add a note in the YCSB post
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add a note in the YCSB post

Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: Add a note in the YCSB post
......................................................................


Add a note in the YCSB post

Last year we posted results in a blog post and recommended users
try some configurations related to flushing. We then changed the
defaults in the next version, but we still see instances of users
taking that post as gospel.

Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Reviewed-on: http://gerrit.cloudera.org:8080/7396
Reviewed-by: Todd Lipcon <to...@apache.org>
Tested-by: Jean-Daniel Cryans <jd...@apache.org>
---
M _posts/2016-04-26-ycsb.md
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Verified
  Todd Lipcon: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7396
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ife414e34388cff6b139580d76d44a2c3477b9abe
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>