You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/07/04 02:44:32 UTC

Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59989/
-----------------------------------------------------------

(Updated July 4, 2017, 10:44 a.m.)


Review request for mesos, Anand Mazumdar and Zhitao Li.


Changes
-------

Rebased.


Bugs: MESOS-7656
    https://issues.apache.org/jira/browse/MESOS-7656


Repository: mesos


Description
-------

Added a test `ProtobufTest.JsonifyMap`.


Diffs (updated)
-----

  3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 


Diff: https://reviews.apache.org/r/59989/diff/3/

Changes: https://reviews.apache.org/r/59989/diff/2-3/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59989/
-----------------------------------------------------------

(Updated Dec. 19, 2017, 9:52 p.m.)


Review request for mesos, Anand Mazumdar and Zhitao Li.


Changes
-------

Addressed review comments.


Bugs: MESOS-7656
    https://issues.apache.org/jira/browse/MESOS-7656


Repository: mesos


Description
-------

Added a test `ProtobufTest.JsonifyMap`.


Diffs (updated)
-----

  3rdparty/stout/tests/protobuf_tests.cpp be35ad0d1e16501df67752a1818f79751419a43d 


Diff: https://reviews.apache.org/r/59989/diff/4/

Changes: https://reviews.apache.org/r/59989/diff/3-4/


Testing
-------

sudo make check


Thanks,

Qian Zhang


Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59989/#review179630
-----------------------------------------------------------



Patch looks great!

Reviews applied: [60109, 59987, 59988, 59989]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 4, 2017, 3:44 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59989/
> -----------------------------------------------------------
> 
> (Updated July 4, 2017, 3:44 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Zhitao Li.
> 
> 
> Bugs: MESOS-7656
>     https://issues.apache.org/jira/browse/MESOS-7656
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ProtobufTest.JsonifyMap`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> 
> Diff: https://reviews.apache.org/r/59989/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59989/#review186037
-----------------------------------------------------------




3rdparty/stout/tests/protobuf_tests.cpp
Lines 607 (patched)
<https://reviews.apache.org/r/59989/#comment262413>

    Please add tests for integral-typed keys.


- Chun-Hung Hsiao


On July 4, 2017, 2:44 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59989/
> -----------------------------------------------------------
> 
> (Updated July 4, 2017, 2:44 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Zhitao Li.
> 
> 
> Bugs: MESOS-7656
>     https://issues.apache.org/jira/browse/MESOS-7656
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ProtobufTest.JsonifyMap`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> 
> Diff: https://reviews.apache.org/r/59989/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Re: Review Request 59989: Added a test `ProtobufTest.JsonifyMap`.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59989/#review179724
-----------------------------------------------------------



Bad patch!

Reviews applied: [59989, 59988, 59987, 60109]

Failed command: python support/apply-reviews.py -n -r 60109

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in <module>
    main()
  File "support/apply-reviews.py", line 412, in main
    reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
    apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
    fetch_patch(options)
  File "support/apply-reviews.py", line 215, in fetch_patch
    shell(cmd, options['dry_run'])
UnboundLocalError: local variable 'cmd' referenced before assignment

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/125/console

- Mesos Reviewbot Windows


On July 3, 2017, 7:44 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59989/
> -----------------------------------------------------------
> 
> (Updated July 3, 2017, 7:44 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Zhitao Li.
> 
> 
> Bugs: MESOS-7656
>     https://issues.apache.org/jira/browse/MESOS-7656
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test `ProtobufTest.JsonifyMap`.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/protobuf_tests.cpp 8877e8934e0f7875bfedcfa88b491ce4b13ca44f 
> 
> 
> Diff: https://reviews.apache.org/r/59989/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>