[GitHub] [iceberg] puchengy commented on a diff in pull request #6552: Throw exception when snapshot expiration operation on snapshot table

[GitBox <gi...@apache.org>]

puchengy commented on code in PR #6552:
URL: https://github.com/apache/iceberg/pull/6552#discussion_r1066080476


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/actions/SnapshotTableSparkAction.java:
##########
@@ -174,7 +174,7 @@ protected Map<String, String> destTableProps() {
 
     // make sure we mark this table as a snapshot table
     properties.put(TableProperties.GC_ENABLED, "false");

Review Comment:
   I think you said is right, I need to rethink this. Thanks for sharing your thought.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org