You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "lwz9103 (via GitHub)" <gi...@apache.org> on 2025/03/21 08:43:18 UTC
[PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
lwz9103 opened a new pull request, #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
(Fixes: \#9085)
## How was this patch tested?
Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2742695540
https://github.com/apache/incubator-gluten/issues/9085
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "lwz9103 (via GitHub)" <gi...@apache.org>.
lwz9103 commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2746794313
@CodiumAI-Agent /review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2742696107
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2746794180
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "CodiumAI-Agent (via GitHub)" <gi...@apache.org>.
CodiumAI-Agent commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2746798803
**[Persistent review](https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2746794976)** updated to latest commit https://github.com/apache/incubator-gluten/commit/5da3b263d1989a8eb7aaf364452e5bbf012803ed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "lwz9103 (via GitHub)" <gi...@apache.org>.
lwz9103 merged PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "CodiumAI-Agent (via GitHub)" <gi...@apache.org>.
CodiumAI-Agent commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2746794976
## PR Reviewer Guide ๐
Here are some key observations to aid the review process:
<table>
<tr><td>
**๐ซ Ticket compliance analysis ๐ถ**
**[9085](https://github.com/apache/incubator-gluten/issues/9085) - Partially compliant**
Compliant requirements:
- Added unit test for mergetree write stats.
- Updated DeltaStats to cap the number of stats columns based on MAX_STATS_COLS.
Non-compliant requirements:
- None
Requires further human verification:
- Verify that the new loop conditions in DeltaStats functions do not cause unintended infinite loops.
</td></tr>
<tr><td>โฑ๏ธ <strong>Estimated effort to review</strong>: 3 ๐ต๐ต๐ตโชโช</td></tr>
<tr><td>๐งช <strong>PR contains tests</strong></td></tr>
<tr><td>๐ <strong>No security concerns identified</strong></td></tr>
<tr><td>โก <strong>Recommended focus areas for review</strong><br><br>
<details><summary><a href='https://github.com/apache/incubator-gluten/pull/9089/files#diff-6023bcc1d7f3a706c2eb3bd78dafb33462cddc0030d05a1d3eb61941bd41d73fR96-R119'><strong>Loop Condition Concern</strong></a>
The newly added for loops in the DeltaStats::statsHeader and update methods use an '||' condition which may lead to unexpected behaviors or potential infinite loops if the column count conditions are not met as expected.
</summary>
```c
size_t num_stats_cols = numStatsCols(output.columns() - partition.size());
auto appendBase = [&](const std::string & prefix)
{
for (size_t i = 0, n = 0; i < output.columns() || n < num_stats_cols; i++)
{
const auto & column = output.getByPosition(i);
if (!partition_index.contains(column.name))
{
statsHeaderBase.emplace_back(wrapNullableType(column.type), prefix + column.name);
++n;
}
}
};
appendBase("min_");
appendBase("max_");
for (size_t i = 0, n = 0; i < output.columns() || n < num_stats_cols; i++)
{
const auto & column = output.getByPosition(i);
if (!partition_index.contains(column.name))
{
statsHeaderBase.emplace_back(BIGINT(), "null_count_" + column.name);
++n;
}
}
```
</details>
</td></tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2746798037
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-9085][CH] Add UT for mergetree write stats [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9089:
URL: https://github.com/apache/incubator-gluten/pull/9089#issuecomment-2747155671
Run Gluten Clickhouse CI on x86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org