You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "tjbanghart (via GitHub)" <gi...@apache.org> on 2023/09/20 15:53:38 UTC

[GitHub] [calcite] tjbanghart commented on a diff in pull request #3434: [CALCITE-6013] Unnecessary measures added as projects during rel cons…

tjbanghart commented on code in PR #3434:
URL: https://github.com/apache/calcite/pull/3434#discussion_r1331860175


##########
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##########
@@ -4690,6 +4690,23 @@ void checkUserDefinedOrderByOver(NullCollation nullCollation) {
         .ok();
   }
 
+  /** Test case for:
+   * <a href="https://issues.apache.org/jira/browse/CALCITE-6013">[CALCITE-6013]
+   * Unnecessary measures added as projects during rel construction</a>.
+   */
+  @Test void testAvoidUnnecessaryMeasureProject() {
+    final String sql = "select deptno\n"
+        + "from empm\n"
+        + "group by deptno";

Review Comment:
   The `GROUP BY` is needed here to trigger the bug correct? Otherwise `createAggImpl` is not called?
   
   Are we certain this issue only impacted aggregate queries?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org