You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hc.apache.org by rs...@apache.org on 2025/10/26 20:05:22 UTC

(httpcomponents-client) branch master updated: Tag TLS handshake timeout tests with `slow`

This is an automated email from the ASF dual-hosted git repository.

rschmitt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/httpcomponents-client.git


The following commit(s) were added to refs/heads/master by this push:
     new 929f5216e Tag TLS handshake timeout tests with `slow`
929f5216e is described below

commit 929f5216ea594c36d2a7d0a4d059d1b78a3a70c3
Author: Ryan Schmitt <rs...@apache.org>
AuthorDate: Sun Oct 26 13:02:31 2025 -0700

    Tag TLS handshake timeout tests with `slow`
    
    These tests don't run reliably on the GitHub CI fleet. I am marking them
    with `@Tag("slow")`, which will cause them to run only when the
    `slow-tests` Maven profile is enabled. We can do the same with any other
    timing-sensitive tests that fail spuriously when running on shared build
    fleets.
---
 .../apache/hc/client5/testing/async/TestAsyncTlsHandshakeTimeout.java   | 2 ++
 .../org/apache/hc/client5/testing/sync/TestTlsHandshakeTimeout.java     | 2 ++
 2 files changed, 4 insertions(+)

diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestAsyncTlsHandshakeTimeout.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestAsyncTlsHandshakeTimeout.java
index ee0583787..aca39d38d 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestAsyncTlsHandshakeTimeout.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/async/TestAsyncTlsHandshakeTimeout.java
@@ -38,6 +38,7 @@
 import org.apache.hc.client5.testing.tls.TlsHandshakeTimeoutServer;
 import org.apache.hc.core5.reactor.IOReactorConfig;
 import org.apache.hc.core5.util.TimeValue;
+import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Timeout;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -57,6 +58,7 @@
 public class TestAsyncTlsHandshakeTimeout {
     private static final Duration EXPECTED_TIMEOUT = Duration.ofMillis(500);
 
+    @Tag("slow")
     @Timeout(5)
     @ParameterizedTest
     @ValueSource(strings = { "false", "true" })
diff --git a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestTlsHandshakeTimeout.java b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestTlsHandshakeTimeout.java
index ca93b2c63..a11378e31 100644
--- a/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestTlsHandshakeTimeout.java
+++ b/httpclient5-testing/src/test/java/org/apache/hc/client5/testing/sync/TestTlsHandshakeTimeout.java
@@ -43,6 +43,7 @@
 import org.apache.hc.client5.testing.tls.TlsHandshakeTimeoutServer;
 import org.apache.hc.core5.http.ClassicHttpRequest;
 import org.apache.hc.core5.http.io.SocketConfig;
+import org.junit.jupiter.api.Tag;
 import org.junit.jupiter.api.Timeout;
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.ValueSource;
@@ -61,6 +62,7 @@
 public class TestTlsHandshakeTimeout {
     private static final Duration EXPECTED_TIMEOUT = Duration.ofMillis(500);
 
+    @Tag("slow")
     @Timeout(5)
     @ParameterizedTest
     @ValueSource(strings = { "false", "true" })