You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/10/31 06:01:00 UTC
[jira] [Updated] (FLINK-14565) Shutdown SystemResourcesCounter on
(JM|TM)MetricGroup closed
[ https://issues.apache.org/jira/browse/FLINK-14565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated FLINK-14565:
-----------------------------------
Labels: pull-request-available (was: )
> Shutdown SystemResourcesCounter on (JM|TM)MetricGroup closed
> ------------------------------------------------------------
>
> Key: FLINK-14565
> URL: https://issues.apache.org/jira/browse/FLINK-14565
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Metrics
> Reporter: Zili Chen
> Assignee: Zili Chen
> Priority: Major
> Labels: pull-request-available
>
> Currently, we start SystemResourcesCounter when initialize (JM|TM)MetricGroup. This thread doesn't exit on (JM|TM)MetricGroup closed and even there is not exit logic of them.
> It possibly causes thread leak. For example, on our platform which supports previewing sample SQL execution, it starts a MiniCluster in the same process as the platform. When the preview job finished MiniCluster closed and also (JM|TM)MetricGroup. However these SystemResourcesCounter threads remain.
> I propose when creating SystemResourcesCounter, track it in (JM|TM)MetricGroup, and on (JM|TM)MetricGroup closed, shutdown SystemResourcesCounter. This way, we survive from thread leaks.
> CC [~chesnay] [~trohrmann]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)