You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/08 15:59:23 UTC
[GitHub] [airflow] kaxil opened a new pull request #13568: Make docs clear that Auth can't be disabled for Stable API
kaxil opened a new pull request #13568:
URL: https://github.com/apache/airflow/pull/13568
There were many users asking this question on Slack (recent one: https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1609834765189300) that disabling auth is not working with new API
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13568:
URL: https://github.com/apache/airflow/pull/13568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13568:
URL: https://github.com/apache/airflow/pull/13568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on a change in pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on a change in pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#discussion_r554049873
##########
File path: docs/apache-airflow/security/api.rst
##########
@@ -57,6 +57,10 @@ If you wish to have the experimental API work, and aware of the risks of enablin
[api]
auth_backend = airflow.api.auth.backend.default
+.. note::
+
+ You can only disable authentication for experimental API not the stable rest API.
Review comment:
Sorry, I should have added these suggestions to the typo.
```suggestion
You can only disable authentication for experimental API, not the stable REST API.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#issuecomment-756865023
> Are you sure about this? I think there is a chance that an unauthenticated user who has the Public role by default will be used. This is a bit limited now as this role has bugs, but we'll probably get it fixed soon. #13340
Yup, that issue you referenced still gives Admin role to public which has not been fixed yet, whenever that is done we can change that but until than this doc change avoids confusion to the users. (2.0.1 might be released sooner and so have this in doc in there is helpful)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#issuecomment-756857234
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#discussion_r554046065
##########
File path: docs/apache-airflow/security/api.rst
##########
@@ -57,6 +57,10 @@ If you wish to have the experimental API work, and aware of the risks of enablin
[api]
auth_backend = airflow.api.auth.backend.default
+.. note::
+
+ You can only disable authentication for experimental API not the sable rest API.
Review comment:
Updated, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#discussion_r554046065
##########
File path: docs/apache-airflow/security/api.rst
##########
@@ -57,6 +57,10 @@ If you wish to have the experimental API work, and aware of the risks of enablin
[api]
auth_backend = airflow.api.auth.backend.default
+.. note::
+
+ You can only disable authentication for experimental API not the sable rest API.
Review comment:
Updated, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#issuecomment-756865023
> Are you sure about this? I think there is a chance that an unauthenticated user who has the Public role by default will be used. This is a bit limited now as this role has bugs, but we'll probably get it fixed soon. #13340
Yup, that issue you referenced still gives Admin role to public which has not been fixed yet, whenever that is done we can change that but until than this doc change avoids confusion to the users. (2.0.1 might be released sooner and so have this in doc in there is helpful)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#issuecomment-756881810
@kaxil This error only affects resources that are associated with the DAG. Other resources, such as variables, are not affected by this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on a change in pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on a change in pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#discussion_r554044579
##########
File path: docs/apache-airflow/security/api.rst
##########
@@ -57,6 +57,10 @@ If you wish to have the experimental API work, and aware of the risks of enablin
[api]
auth_backend = airflow.api.auth.backend.default
+.. note::
+
+ You can only disable authentication for experimental API not the sable rest API.
Review comment:
```suggestion
You can only disable authentication for experimental API not the stable rest API.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton commented on a change in pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on a change in pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#discussion_r554044579
##########
File path: docs/apache-airflow/security/api.rst
##########
@@ -57,6 +57,10 @@ If you wish to have the experimental API work, and aware of the risks of enablin
[api]
auth_backend = airflow.api.auth.backend.default
+.. note::
+
+ You can only disable authentication for experimental API not the sable rest API.
Review comment:
```suggestion
You can only disable authentication for experimental API not the stable rest API.
```
##########
File path: docs/apache-airflow/security/api.rst
##########
@@ -57,6 +57,10 @@ If you wish to have the experimental API work, and aware of the risks of enablin
[api]
auth_backend = airflow.api.auth.backend.default
+.. note::
+
+ You can only disable authentication for experimental API not the stable rest API.
Review comment:
Sorry, I should have added these suggestions to the typo.
```suggestion
You can only disable authentication for experimental API, not the stable REST API.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13568: Make docs clear that Auth can't be disabled for Stable API
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13568:
URL: https://github.com/apache/airflow/pull/13568#issuecomment-756857234
Are you sure about this? I think there is a chance that an unauthenticated user who has the Public role by default will be used. This is a bit limited now as this role has bugs, but we'll probably get it fixed soon. https://github.com/apache/airflow/issues/13340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org