You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "wasphin (via GitHub)" <gi...@apache.org> on 2026/09/13 07:37:28 UTC

[PR] Stabilize timer and socket unit tests (brpc)

wasphin opened a new pull request, #3540:
URL: https://github.com/apache/brpc/pull/3540

   ### What problem does this PR solve?
   
   Issue Number:
   
   Problem Summary:
   
   Two unit tests can fail under CI load because they rely on tight timing
   assumptions. The timer test requires shutdown within 15 milliseconds, and the
   socket test releases its socket after a fixed 50-millisecond delay without
   ensuring that all asynchronous write callbacks have completed.
   
   ### What is changed and the side effects?
   
   Changed:
   
   - Keep the timer shutdown latency check well below the next scheduled task
     while allowing for CI runner scheduling delays.
   - Wait for all shutdown-write callbacks with a bounded countdown event before
     releasing the socket.
   - Stop repeated shutdown-write runs after the first test failure.
   
   Side effects:
   
   - Performance effects: Normal runs no longer incur the fixed 50-millisecond
     delay in every shutdown-write iteration.
   - Breaking backward compatibility: None.
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [PR] Stabilize timer and socket unit tests (brpc)

Posted by "chenBright (via GitHub)" <gi...@apache.org>.
chenBright merged PR #3540:
URL: https://github.com/apache/brpc/pull/3540


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org