[GitHub] [superset] villebro commented on a diff in pull request #20323: feat: safer insert RLS

[GitBox <gi...@apache.org>]

villebro commented on code in PR #20323:
URL: https://github.com/apache/superset/pull/20323#discussion_r1006183775


##########
tests/unit_tests/sql_parse_tests.py:
##########
@@ -1221,6 +1222,151 @@ def test_has_table_query(sql: str, expected: bool) -> None:
     assert has_table_query(statement) == expected
 
 
+@pytest.mark.parametrize(

Review Comment:
   Reading through these tests I wonder how this handles aliases, something like
   ```
   SELECT a.*, b.*
   FROM tbl_a AS a
   INNER JOIN tbl_b AS b ON a.col = b.col
   ```
   
   also the shorthand form (or combo of them)
   
   ```
   SELECT a.*, b.*
   FROM tbl_a a
   INNER JOIN tbl_b b ON a.col = b.col
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org