You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/06 20:45:49 UTC

[GitHub] [kafka] vincent81jiang commented on a diff in pull request #12516: KAFKA-14151: validate offsets of input records before writing them file

vincent81jiang commented on code in PR #12516:
URL: https://github.com/apache/kafka/pull/12516#discussion_r964150701


##########
core/src/main/scala/kafka/log/LogSegment.scala:
##########
@@ -176,10 +179,28 @@ class LogSegment private[log] (val log: FileRecords,
       throw new LogSegmentOffsetOverflowException(this, offset)
   }
 
+  /**
+   * Validate that offsets of records are monotonically increasing and are in [offsetLowerBound, offsetUpperBound] range.

Review Comment:
   Right. Will fix the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org