You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Danny Robinson (JIRA)" <ad...@incubator.apache.org> on 2006/12/04 23:26:21 UTC
[jira] Created: (ADFFACES-317) inputDate should not render icon if
'chooseId' specified
inputDate should not render icon if 'chooseId' specified
--------------------------------------------------------
Key: ADFFACES-317
URL: http://issues.apache.org/jira/browse/ADFFACES-317
Project: MyFaces ADF-Faces
Issue Type: Improvement
Reporter: Danny Robinson
Priority: Minor
The current <tr:inputDate> implementation always renders an icon immediately following the input field. However, if you specify a <tr:chooseDate> to render the calendar in-page, it shouldn't render the icon. A simple patch to SimpleInputDateRenderer fixes this (below).
PATCH to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputDateRenderer
@Override
protected void renderAfterTextField(
FacesContext context,
RenderingContext arc,
UIComponent component,
FacesBean bean) throws IOException
{
// Only render the icon if chooseId is not specified.
if (_getChooseId(arc) == null)
super.renderAfterTextField(context, arc, component, bean);
}
By the way, this fix will cause CoreRenderKitTest to fail, so will require an update to the expected/golden output for this component. Sorry - I'm not yet familiar enough to do this.
Thanks,
Danny
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-317) inputDate should not render icon if
'chooseId' specified
Posted by "Danny Robinson (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-317?page=all ]
Danny Robinson updated ADFFACES-317:
------------------------------------
Status: Patch Available (was: Open)
> inputDate should not render icon if 'chooseId' specified
> --------------------------------------------------------
>
> Key: ADFFACES-317
> URL: http://issues.apache.org/jira/browse/ADFFACES-317
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Danny Robinson
> Priority: Minor
>
> The current <tr:inputDate> implementation always renders an icon immediately following the input field. However, if you specify a <tr:chooseDate> to render the calendar in-page, it shouldn't render the icon. A simple patch to SimpleInputDateRenderer fixes this (below).
> PATCH to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputDateRenderer
> @Override
> protected void renderAfterTextField(
> FacesContext context,
> RenderingContext arc,
> UIComponent component,
> FacesBean bean) throws IOException
> {
> // Only render the icon if chooseId is not specified.
> if (_getChooseId(arc) == null)
> super.renderAfterTextField(context, arc, component, bean);
> }
> By the way, this fix will cause CoreRenderKitTest to fail, so will require an update to the expected/golden output for this component. Sorry - I'm not yet familiar enough to do this.
> Thanks,
> Danny
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-317) inputDate should not render icon if
'chooseId' specified
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-317:
----------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> inputDate should not render icon if 'chooseId' specified
> --------------------------------------------------------
>
> Key: ADFFACES-317
> URL: https://issues.apache.org/jira/browse/ADFFACES-317
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Affects Versions: 1.0.0-incubating-core
> Reporter: Danny Robinson
> Priority: Minor
> Fix For: 1.0.0-incubating-core
>
>
> The current <tr:inputDate> implementation always renders an icon immediately following the input field. However, if you specify a <tr:chooseDate> to render the calendar in-page, it shouldn't render the icon. A simple patch to SimpleInputDateRenderer fixes this (below).
> PATCH to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputDateRenderer
> @Override
> protected void renderAfterTextField(
> FacesContext context,
> RenderingContext arc,
> UIComponent component,
> FacesBean bean) throws IOException
> {
> // Only render the icon if chooseId is not specified.
> if (_getChooseId(arc) == null)
> super.renderAfterTextField(context, arc, component, bean);
> }
> By the way, this fix will cause CoreRenderKitTest to fail, so will require an update to the expected/golden output for this component. Sorry - I'm not yet familiar enough to do this.
> Thanks,
> Danny
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-317) inputDate should not render icon if
'chooseId' specified
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-317?page=all ]
Adam Winer updated ADFFACES-317:
--------------------------------
Status: Resolved (was: Patch Available)
Resolution: Fixed
Checked in.
> inputDate should not render icon if 'chooseId' specified
> --------------------------------------------------------
>
> Key: ADFFACES-317
> URL: http://issues.apache.org/jira/browse/ADFFACES-317
> Project: MyFaces ADF-Faces
> Issue Type: Improvement
> Reporter: Danny Robinson
> Priority: Minor
>
> The current <tr:inputDate> implementation always renders an icon immediately following the input field. However, if you specify a <tr:chooseDate> to render the calendar in-page, it shouldn't render the icon. A simple patch to SimpleInputDateRenderer fixes this (below).
> PATCH to org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.SimpleInputDateRenderer
> @Override
> protected void renderAfterTextField(
> FacesContext context,
> RenderingContext arc,
> UIComponent component,
> FacesBean bean) throws IOException
> {
> // Only render the icon if chooseId is not specified.
> if (_getChooseId(arc) == null)
> super.renderAfterTextField(context, arc, component, bean);
> }
> By the way, this fix will cause CoreRenderKitTest to fail, so will require an update to the expected/golden output for this component. Sorry - I'm not yet familiar enough to do this.
> Thanks,
> Danny
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira