You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "notfilippo (via GitHub)" <gi...@apache.org> on 2025/12/19 09:30:07 UTC
[I] Create a Cargo feature flag for each sketch (datasketches-rust)
notfilippo opened a new issue, #32:
URL: https://github.com/apache/datasketches-rust/issues/32
Motivation:
1. We can gate compiler warnings only when certain sketches are tying to be compiled on unsupported platforms (e.g. #28)
2. We can allow users to pick and choose their sketches without having to compile the whole crate
By default, all sketches should be turned on IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [I] Create a Cargo feature flag for each sketch (datasketches-rust)
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #32:
URL: https://github.com/apache/datasketches-rust/issues/32#issuecomment-3674450816
Adding `full` in default can be quiet pain. I prefer to let users to pick sketchs they need.
> But we can start with simple hll/cpc/tdigest and only use a namespace prefix when we need it.
This LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [I] Create a Cargo feature flag for each sketch (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun closed issue #32: Create a Cargo feature flag for each sketch
URL: https://github.com/apache/datasketches-rust/issues/32
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [I] Create a Cargo feature flag for each sketch (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #32:
URL: https://github.com/apache/datasketches-rust/issues/32#issuecomment-3677810635
> Adding `full` in default can be quiet pain. I prefer to let users to pick sketchs they need.
Yeah .. I like `default = []` as well. Explicit over implicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [I] Create a Cargo feature flag for each sketch (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #32:
URL: https://github.com/apache/datasketches-rust/issues/32#issuecomment-3674293025
```toml
default = [ "full" ]
```
Lol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [I] Create a Cargo feature flag for each sketch (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on issue #32:
URL: https://github.com/apache/datasketches-rust/issues/32#issuecomment-4394841231
Once https://github.com/apache/datasketches-rust/pull/118 resolved, I'd get into this issue.
I can foresee that with agentic tools this should be implemented easily.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org