[GitHub] [nifi] adenes commented on a change in pull request #4550: NIFI-7843 Recursive avro schemas fail to write with RecordWriter

[GitBox <gi...@apache.org>]

adenes commented on a change in pull request #4550:
URL: https://github.com/apache/nifi/pull/4550#discussion_r495918956



##########
File path: nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/SimpleRecordSchema.java
##########
@@ -167,6 +167,11 @@ public boolean equals(final Object obj) {
         }
 
         final RecordSchema other = (RecordSchema) obj;
+        if (getSchemaNamespace().isPresent() && getSchemaNamespace().equals(other.getSchemaNamespace()) &&
+                getSchemaName().isPresent() && getSchemaName().equals(other.getSchemaName())) {
+            return true;
+        }
+

Review comment:
       Thanks @simonbence for the comment, I added a new test case to the TestSimpleRecordSchema




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org