You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alexey Sviridov (JIRA)" <ji...@apache.org> on 2012/08/30 07:58:07 UTC

[jira] [Created] (QPID-4269) Qpid windows service ignore service parameters

Alexey Sviridov created QPID-4269:
-------------------------------------

             Summary: Qpid windows service ignore service parameters
                 Key: QPID-4269
                 URL: https://issues.apache.org/jira/browse/QPID-4269
             Project: Qpid
          Issue Type: Bug
          Components: C++ Broker
    Affects Versions: 0.16, 0.14
         Environment: Windows
            Reporter: Alexey Sviridov


When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Alexey Sviridov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446903#comment-13446903 ] 

Alexey Sviridov commented on QPID-4269:
---------------------------------------

BTW when i'm investigate this bug i'm found a functions GetCommandLineW and CommandLineToArgvW. I'm don't enough time to play with it, but may be this is better way to get argc and argv parameters in ServiceMain function, isn't it?
                
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>            Assignee: Steve Huston
>         Attachments: qpid-4269.patch, scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Resolved] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Steve Huston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston resolved QPID-4269.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.19

Using GetCommandLine would be slightly more elegant, but not add any better functionality. Since I already have this working and changing it won't improve the situation, I'm going to leave it as is, at least for now.

Fixed on trunk at r1380890.
                
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>            Assignee: Steve Huston
>             Fix For: 0.19
>
>         Attachments: qpid-4269.patch, scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Alexey Sviridov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Sviridov updated QPID-4269:
----------------------------------

    Attachment: scm_args.patch

apply through patch -p1
                
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>         Attachments: scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Commented] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Alexey Sviridov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444734#comment-13444734 ] 

Alexey Sviridov commented on QPID-4269:
---------------------------------------

After a brief study of this error, I realized when qpid starts as a service he get arguments from function ServiceMain(argc, argv). But params stored in service passed not to ServiceMain, but to main(argc, argv). When the main determines that it is not running from a console, it's start ServiceMain without arguments.
There is two possible solution at first look 
1. fast and bad - pass these parameters ServiceMain through global variables
2. slow and good - get command line arguments right in ServiceMain, or pass arguments by another way
Actually i'm from java world and wrote last C++ line about six years ago, so my choice was first of course.
So my patch very ugly but works. I'm thionk someone can do this much better

                
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>         Attachments: scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Assigned] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Steve Huston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston reassigned QPID-4269:
----------------------------------

    Assignee: Steve Huston
    
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>            Assignee: Steve Huston
>         Attachments: scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Comment Edited] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Alexey Sviridov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446903#comment-13446903 ] 

Alexey Sviridov edited comment on QPID-4269 at 9/2/12 8:52 PM:
---------------------------------------------------------------

BTW when i'm investigate this bug i'm found a functions GetCommandLineW and CommandLineToArgvW. I'm don't enough time to play with it, but may be this is better way to get argc and argv parameters right in ServiceMain function, isn't it?
                
      was (Author: sviridov_alexey):
    BTW when i'm investigate this bug i'm found a functions GetCommandLineW and CommandLineToArgvW. I'm don't enough time to play with it, but may be this is better way to get argc and argv parameters in ServiceMain function, isn't it?
                  
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>            Assignee: Steve Huston
>         Attachments: qpid-4269.patch, scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Comment Edited] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Alexey Sviridov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446903#comment-13446903 ] 

Alexey Sviridov edited comment on QPID-4269 at 9/5/12 5:28 PM:
---------------------------------------------------------------

BTW when i'm investigate this bug i'm found a functions GetCommandLineW and CommandLineToArgvW. I'm don't have enough time to play with it, but may be this is better way to get argc and argv parameters right in ServiceMain function, isn't it?
                
      was (Author: sviridov_alexey):
    BTW when i'm investigate this bug i'm found a functions GetCommandLineW and CommandLineToArgvW. I'm don't enough time to play with it, but may be this is better way to get argc and argv parameters right in ServiceMain function, isn't it?
                  
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>            Assignee: Steve Huston
>             Fix For: 0.19
>
>         Attachments: qpid-4269.patch, scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[jira] [Updated] (QPID-4269) Qpid windows service ignore service parameters

Posted by "Steve Huston (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-4269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steve Huston updated QPID-4269:
-------------------------------

    Attachment: qpid-4269.patch

Revised and expanded patch. Also put up on review board for input before committing.
                
> Qpid windows service ignore service parameters
> ----------------------------------------------
>
>                 Key: QPID-4269
>                 URL: https://issues.apache.org/jira/browse/QPID-4269
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.14, 0.16
>         Environment: Windows
>            Reporter: Alexey Sviridov
>            Assignee: Steve Huston
>         Attachments: qpid-4269.patch, scm_args.patch
>
>
> When installing qpid as windows service (i.e. by command qpidd.exe --install --arguments --no-data-dir) qpid create service with arguments. It's fine, while you don't try to start created service. When starting servce qpid starts, but ignore all params. To be honest there is way to start service with params (by specifying they in another place for params in service dialog (greeting windows!)) but for only one start, this params not saved after closing service properties dialog

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org