You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/24 17:01:14 UTC
[GitHub] [nifi] javiroman opened a new pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command
javiroman opened a new pull request #4358:
URL: https://github.com/apache/nifi/pull/4358
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
This PR add a new command in the CLI for creating Process Group in the root PG:
bin/cli.sh nifi pg-create -pgn Team1
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651772910
Not sure if this is the reason, but try running "install" instead of "compile".
Here was the output for me:
```
[INFO] --- maven-checkstyle-plugin:3.1.0:check (check-style) @ nifi-toolkit-cli ---
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[19,8] (imports) UnusedImports: Unused import - org.apache.commons.lang3.StringUtils.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[29,8] (imports) UnusedImports: Unused import - org.apache.nifi.toolkit.cli.impl.result.nifi.ProcessGroupsResult.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[31,8] (imports) UnusedImports: Unused import - org.apache.nifi.web.api.dto.UserDTO.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[32,8] (imports) UnusedImports: Unused import - org.apache.nifi.web.api.dto.flow.FlowDTO.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[33,8] (imports) UnusedImports: Unused import - org.apache.nifi.web.api.dto.flow.ProcessGroupFlowDTO.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[34,8] (imports) UnusedImports: Unused import - org.apache.nifi.web.api.entity.ControllerServiceEntity.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[36,8] (imports) UnusedImports: Unused import - org.apache.nifi.web.api.entity.ProcessGroupFlowEntity.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[37,8] (imports) UnusedImports: Unused import - org.apache.nifi.web.api.entity.UserEntity.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[40,8] (imports) UnusedImports: Unused import - java.util.ArrayList.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[41,8] (imports) UnusedImports: Unused import - java.util.List.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[49,23] (blocks) LeftCurly: '{' at column 23 should have line break after.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[52,36] (blocks) LeftCurly: '{' at column 36 should have line break after.
[WARNING] src/main/java/org/apache/nifi/toolkit/cli/impl/command/nifi/pg/PGCreate.java:[55,50] (blocks) LeftCurly: '{' at column 50 should have line break after.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] javiroman commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command
Posted by GitBox <gi...@apache.org>.
javiroman commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651557340
Unfortunately I'm not getting checkstyle errors. The build command is:
Anyway I've just removed some unused imports.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4358:
URL: https://github.com/apache/nifi/pull/4358
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651803038
Looks good, merged to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] bbende commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651336958
Running a build inside `nifi-toolkit` with `-Pcontrib-check` shows some checkstyle errors that would need to be resolved. For some reason there is an issue where builds through Github Actions are not catching these so it shows everything as passing, we are looking into that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] javiroman commented on pull request #4358: NIFI-7578 nifi-toolkit CLI Process Group Create command
Posted by GitBox <gi...@apache.org>.
javiroman commented on pull request #4358:
URL: https://github.com/apache/nifi/pull/4358#issuecomment-651786555
mvn -P contrib-check clean install
from the command line (out of IDEA IDE) raised the style checker. Any kind of configuration of my IDEA IDE is avoiding the correct behaviour.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org