You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/24 06:19:46 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request #12956: [Docker] Enable filesystem permission updates in derivative docker im…
michaeljmarshall opened a new pull request #12956:
URL: https://github.com/apache/pulsar/pull/12956
…ages
Master Issue: https://github.com/apache/pulsar/issues/11269 and https://github.com/apache/pulsar/pull/8242
### Motivation
@roelrymenants points out in https://github.com/apache/pulsar/pull/8242:
> On OpenShift the user id in the container is random. In this case, the /pulsar folder has problematic permissions. The VOLUME statement even locks these into place for derivative images.
I realized today that because we removed the standalone docker image in https://github.com/apache/pulsar/pull/11657, we can now removed the `VOLUME` command in the dockerfile and make it easier for end users to extend the pulsar docker image. I describe moving the `VOLUME` command here https://github.com/apache/pulsar/pull/8796#issuecomment-774608357.
I think I should be able to make the pulsar docker images OpenShift compliant and non-root by default in early December. Until then, it is still valuable to update docker image to make it easier for end users to extend the image.
### Modifications
* Remove the `VOLUME` directive from the `pulsar` dockerfile.
### Verifying this change
Now that we removed the standalone docker image, there is no need for the `VOLUME` command.
### Does this pull request potentially affect one of the following parts:
This is not a breaking change.
### Documentation
- [x] `no-need-doc`
This is a minor feature that does not need documentation. I'll provide docs when I update the pulsar docker image to be non-root/OpenShift compliant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] timmyyuan commented on pull request #12956: [Docker] Enable filesystem permission updates in derivative docker im…
Posted by GitBox <gi...@apache.org>.
timmyyuan commented on pull request #12956:
URL: https://github.com/apache/pulsar/pull/12956#issuecomment-979589974
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #12956: [Docker] Enable filesystem permission updates in derivative docker im…
Posted by GitBox <gi...@apache.org>.
michaeljmarshall commented on pull request #12956:
URL: https://github.com/apache/pulsar/pull/12956#issuecomment-977567365
@lhotari - PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] freeznet commented on pull request #12956: [Docker] Enable filesystem permission updates in derivative docker im…
Posted by GitBox <gi...@apache.org>.
freeznet commented on pull request #12956:
URL: https://github.com/apache/pulsar/pull/12956#issuecomment-978784864
@timmyyuan please help to review this PR when you have time, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] merlimat merged pull request #12956: [Docker] Enable filesystem permission updates in derivative docker im…
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #12956:
URL: https://github.com/apache/pulsar/pull/12956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org