You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/09/26 23:41:28 UTC
Review Request 62601: Remove the rewriteConfigs thrift method
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/
-----------------------------------------------------------
Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
Repository: aurora
Description
-------
Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
Diffs
-----
RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
Diff: https://reviews.apache.org/r/62601/diff/1/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186344
-----------------------------------------------------------
Master (79ff364) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/aurora/common/test_clusters.py::test_load [32mPASSED[0m
src/test/python/apache/aurora/common/test_clusters.py::test_load_invalid_syntax [32mPASSED[0m
src/test/python/apache/aurora/common/test_clusters.py::test_patch_cleanup_on_error [32mPASSED[0m
src/test/python/apache/aurora/common/test_shellify.py::test_shellify [32mPASSED[0m
src/test/python/apache/aurora/common/test_cluster.py::test_simple [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_construction [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_ephemerals [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_daemons [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_finish_with_daemon_ephemerals [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_process_cannot_depend_upon_daemon [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_non_ephemeral_process_cannot_depend_on_ephemeral_process [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_failed_predecessor_does_not_make_process_runnable [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_daemon_duration [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_waits [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_fails [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_lost [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_filters [32mPASSED[0m
src/test/python/apache/thermos/common/test_task_planner.py::test_task_max_runs [32mPASSED[0m
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_task_roots [32mPASSED[0m
src/test/python/apache/thermos/common/test_pathspec.py::test_legacy_log_dirs [32mPASSED[0m
src/test/python/apache/thermos/common/test_pathspec.py::test_exception_on_none_keys [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_empty [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_unordered [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_ordered [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_mixed [32mPASSED[0m
src/test/python/apache/thermos/common/test_planner.py::test_planner_unsatisfiables [32mPASSED[0m
===================== ERRORS =====================
ERROR collecting src/test/python/apache/aurora/client/api/test_scheduler_client.py
src/test/python/apache/aurora/client/api/test_scheduler_client.py:36: in <module>
[1m from gen.apache.aurora.api.ttypes import ([0m
[1m[31mE ImportError: cannot import name RewriteConfigsRequest[0m
generated xml file: /home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/aaf4d108c31293299a0839bdc404a91802f80937.xml
[1m[31m 720 passed, 6 skipped, 1 warnings, 1 error in 306.05 seconds [0m
FAILURE
00:05:18 05:41 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 26, 2017, 11:41 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 11:41 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
>
>
> Diff: https://reviews.apache.org/r/62601/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 27, 2017, 12:33 p.m., Stephan Erb wrote:
> > I love commits that are just pure removal :)
> >
> > Please send a mail to the dev mailing list though that we are dropping the feature without a deprecation cycle. If somebody really cares strongly (which I doubt) he/she has a chance to let us know.
Done. I'll give it ~48 hours before landing this.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186466
-----------------------------------------------------------
On Sept. 26, 2017, 5:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 5:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186466
-----------------------------------------------------------
Ship it!
I love commits that are just pure removal :)
Please send a mail to the dev mailing list though that we are dropping the feature without a deprecation cycle. If somebody really cares strongly (which I doubt) he/she has a chance to let us know.
- Stephan Erb
On Sept. 27, 2017, 2:20 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 2:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Bill Farner <wf...@apache.org>.
> On Sept. 29, 2017, 1:04 p.m., Reza Motamedi wrote:
> > Should we also remove this:
> >
> > https://github.com/apache/aurora/blob/243d6fa14fb46eec79de6b1f7f55a4c1937ee8f5/src/test/python/apache/aurora/api_util.py#L70-L71
Thanks! Removed.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186738
-----------------------------------------------------------
On Sept. 26, 2017, 5:20 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 5:20 p.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/api_util.py 41441f3fa5558dbca5b3a5473b3a3cacac6ff463
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Reza Motamedi <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186738
-----------------------------------------------------------
Ship it!
Should we also remove this:
https://github.com/apache/aurora/blob/243d6fa14fb46eec79de6b1f7f55a4c1937ee8f5/src/test/python/apache/aurora/api_util.py#L70-L71
- Reza Motamedi
On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186357
-----------------------------------------------------------
Ship it!
Master (79ff364) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by David McLaughlin <da...@dmclaughlin.com>.
> On Sept. 27, 2017, 5:21 a.m., David McLaughlin wrote:
> > Ship It!
+1 from Twitter for skipping the deprecation cycle - we do not use this.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186374
-----------------------------------------------------------
On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186374
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186746
-----------------------------------------------------------
Ship it!
Master (7a80373) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/api_util.py 41441f3fa5558dbca5b3a5473b3a3cacac6ff463
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/#review186734
-----------------------------------------------------------
Ship it!
Ship It!
- Jordan Ly
On Sept. 27, 2017, 12:20 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62601/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 12:20 a.m.)
>
>
> Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
>
>
> Diffs
> -----
>
> RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
> api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
> api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
> src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
> src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
> src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
> src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
> src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
> src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
> src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
> src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
> src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
>
>
> Diff: https://reviews.apache.org/r/62601/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62601: Remove the rewriteConfigs thrift method
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62601/
-----------------------------------------------------------
(Updated Sept. 26, 2017, 5:20 p.m.)
Review request for Aurora, David McLaughlin, Jordan Ly, and Stephan Erb.
Changes
-------
Address python build. Apologies for using jenkins to validate the py build - updated macOS and can't build python yet, need to address separately.
Repository: aurora
Description
-------
Consider this somewhere between 'proposal' and 'discussion starter'. I think this behavior should die, reasons noted in `RELEASE-NOTES.md`. Normally i would support a deprecation cycle, but i think this is safe to short-circuit due to the obscurity (no tools provided that use this, no documentation, no known uses) along with the inherent riskiness of using it.
Diffs (updated)
-----
RELEASE-NOTES.md fd2618fee8ef05091849e177bd99fc321548be90
api/src/main/thrift/org/apache/aurora/gen/api.thrift 3749531b5412d7ca217736aa85eed8e6606225ad
api/src/main/thrift/org/apache/aurora/gen/storage.thrift 9e4213f13255a182df938bea44ca87fa03a25318
src/main/java/org/apache/aurora/scheduler/storage/TaskStore.java 1094a122fe836e53d0481ee5c097447f1e91fa0a
src/main/java/org/apache/aurora/scheduler/storage/db/DbTaskStore.java 5af1a798db659f1934ab35bb6a77afaa4b45b47c
src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java 387350c7667a5fb8ee674ad0d3dd17529232b25b
src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d
src/main/java/org/apache/aurora/scheduler/storage/mem/MemTaskStore.java 964e2fc82eca5b3a40ce4419c5de80bdea32fa72
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 7ea6fc4c7667270541cd964eb39446bc9af3c796
src/main/python/apache/aurora/client/api/__init__.py 7efafd3f0124e453f68f29861fc4ca444e19abde
src/test/java/org/apache/aurora/scheduler/storage/AbstractTaskStoreTest.java 69c35b1fb4da052243e5022f3bbc2ec186f1d216
src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java 0eb54fdaddfbc2af76fd83ffee18ce4c6b61cc48
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 9c446682750706aecdc67062ae82f2a76ab38043
src/test/python/apache/aurora/client/api/test_scheduler_client.py b2fd4d929227124c5fdce24dac38488b8ec66bdd
Diff: https://reviews.apache.org/r/62601/diff/2/
Changes: https://reviews.apache.org/r/62601/diff/1-2/
Testing
-------
Thanks,
Bill Farner