You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "theirix (via GitHub)" <gi...@apache.org> on 2024/09/05 21:24:05 UTC
[PR] Support for SIMILAR TO for physical plan [datafusion]
theirix opened a new pull request, #12350:
URL: https://github.com/apache/datafusion/pull/12350
## Which issue does this PR close?
Add support for SIMILAR TO and NOT SIMILAR TO to the physical plan.
Closes #12155.
## Rationale for this change
Currently, a simple query `select * from t1 where c1 similar to 'x*'` is not supported.
## What changes are included in this PR?
- Support for "SIMILAR TO" family operator in physical plan
- Additional sqllogic tests
The functionality is based on creating a binary expression for `Operator::RegexMatch` and family.
There is an existing `like` module for the LIKE operator. Probably, this functionality can be extracted to a similar `similar_to` module.
## Are these changes tested?
- unit test (for binary operator only)
- sqllogictest integration test
- manual test using `datafusion-cli`
- tested with additional operators for expression and pattern
## Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support for SIMILAR TO for physical plan [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #12350:
URL: https://github.com/apache/datafusion/pull/12350#issuecomment-2334244259
> There is an existing like module for the LIKE operator. Probably, this functionality can be extracted to a similar similar_to module.
Perhaps you could do this as a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support for SIMILAR TO for physical plan [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #12350:
URL: https://github.com/apache/datafusion/pull/12350#issuecomment-2337843820
Thanks again @theirix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support for SIMILAR TO for physical plan [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #12350:
URL: https://github.com/apache/datafusion/pull/12350
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Support for SIMILAR TO for physical plan [datafusion]
Posted by "theirix (via GitHub)" <gi...@apache.org>.
theirix commented on PR #12350:
URL: https://github.com/apache/datafusion/pull/12350#issuecomment-2337967670
> Thanks again @theirix
Sure! It allowed me to better understand the datafusion internals
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org