You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/04 02:33:08 UTC
[GitHub] [tvm] yogurfrul opened a new pull request #10481: [Torch] fix torch version check bug
yogurfrul opened a new pull request #10481:
URL: https://github.com/apache/tvm/pull/10481
old code checkout "1.10.2" greater_than "1.5.0" if false, fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10481: [Torch] fix torch version check bug
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10481:
URL: https://github.com/apache/tvm/pull/10481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yogurfrul commented on pull request #10481: [Torch] fix torch version check bug
Posted by GitBox <gi...@apache.org>.
yogurfrul commented on pull request #10481:
URL: https://github.com/apache/tvm/pull/10481#issuecomment-1058774805
>
o, older code without int is bug.
curruent code with int is ok , while would fail with "1.10.2" vs "1.5" case
regex is not easy to understand, LooseVersion looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10481: [Torch] fix torch version check bug
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10481:
URL: https://github.com/apache/tvm/pull/10481#issuecomment-1058778497
Yeah I think I added `int` there recently. Good to see the ugly regex removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #10481: [Torch] fix torch version check bug
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #10481:
URL: https://github.com/apache/tvm/pull/10481#issuecomment-1058771277
LGTM but why the old code failed on that example? Isn't it 1102 vs 150?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org