You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/12/15 10:39:05 UTC
[GitHub] [incubator-hugegraph-commons] imbajin opened a new pull request, #124: fix(dist): generate doc & exit script when upload files failed
imbajin opened a new pull request, #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124
NOTE: DON'T DELETE THIS BRANCH (afer merge it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] javeme commented on a diff in pull request #124: fix(dist): generate doc & exit script when upload files failed
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124#discussion_r1051409826
##########
hugegraph-dist/scripts/apache-release.sh:
##########
@@ -92,9 +95,10 @@ svn status
##### 4.3 commit & push files
if [ "$USERNAME" = "" ]; then
- svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}"
+ svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" || exit
Review Comment:
prefer to add "set -ev" in the file header
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] javeme commented on a diff in pull request #124: fix(dist): generate doc & exit script when upload files failed
Posted by GitBox <gi...@apache.org>.
javeme commented on code in PR #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124#discussion_r1051600408
##########
hugegraph-dist/scripts/apache-release.sh:
##########
@@ -92,9 +95,10 @@ svn status
##### 4.3 commit & push files
if [ "$USERNAME" = "" ]; then
- svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}"
+ svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" || exit
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #124: fix(dist): generate doc & exit script when upload files failed
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124#discussion_r1049482593
##########
pom.xml:
##########
@@ -279,7 +276,7 @@
<profiles>
<profile>
- <id>release</id>
+ <id>apache-release</id>
Review Comment:
@coderzc @zyxxoo @z7658329
seems we should use `apache-release` id here to override the settings when execute `mvn xx -Papache-release`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] codecov[bot] commented on pull request #124: fix(dist): generate doc & exit script when upload files failed
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124#issuecomment-1352874666
# [Codecov](https://codecov.io/gh/apache/incubator-hugegraph-commons/pull/124?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#124](https://codecov.io/gh/apache/incubator-hugegraph-commons/pull/124?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c93682) into [master](https://codecov.io/gh/apache/incubator-hugegraph-commons/commit/9463119a67bb786a4290360546741bad554cfed2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9463119) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #124 +/- ##
=========================================
Coverage 93.15% 93.15%
Complexity 65 65
=========================================
Files 9 9
Lines 263 263
Branches 22 22
=========================================
Hits 245 245
Misses 8 8
Partials 10 10
```
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on pull request #124: fix(dist): generate doc & exit script when upload files failed
Posted by GitBox <gi...@apache.org>.
imbajin commented on PR #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124#issuecomment-1380394798
rebase & merge this PR, so as other `release-1.0.0 -> master`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin merged pull request #124: fix(dist): generate doc & exit script when upload files failed
Posted by GitBox <gi...@apache.org>.
imbajin merged PR #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hugegraph-commons] imbajin commented on a diff in pull request #124: fix(dist): generate doc & exit script when upload files failed
Posted by GitBox <gi...@apache.org>.
imbajin commented on code in PR #124:
URL: https://github.com/apache/incubator-hugegraph-commons/pull/124#discussion_r1051573761
##########
hugegraph-dist/scripts/apache-release.sh:
##########
@@ -92,9 +95,10 @@ svn status
##### 4.3 commit & push files
if [ "$USERNAME" = "" ]; then
- svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}"
+ svn commit -m "submit files for ${REPO} ${RELEASE_VERSION}" || exit
Review Comment:
It was added before, but the output content is **too much** and makes a little messy
consider test & add it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org