You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/24 10:13:29 UTC

[GitHub] [airflow] potiuk commented on a change in pull request #7683: [AIRFLOW-7033] Change dag and task state meanwhile

potiuk commented on a change in pull request #7683: [AIRFLOW-7033] Change dag and task state meanwhile
URL: https://github.com/apache/airflow/pull/7683#discussion_r397038865
 
 

 ##########
 File path: airflow/api/common/experimental/mark_tasks.py
 ##########
 @@ -312,8 +374,6 @@ def set_dag_run_state_to_success(dag, execution_date, commit=False, session=None
         _set_dag_run_state(dag.dag_id, execution_date, State.SUCCESS, session)
 
     # Mark all task instances of the dag run to success.
-    for task in dag.tasks:
-        task.dag = dag
 
 Review comment:
   Not sure. @mik-laj -> maybe you can take a look, you know much better now how changing state works and whether this change will be ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services