You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2016/11/04 16:49:51 UTC
[kudu-CR] [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4948
to review the following change.
Change subject: [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
......................................................................
[java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
We were logging the RPC after calling errback on it, so some of the fields were
already nulled out. Mostly a cosmetic change, for a DEBUG log line.
Change-Id: If3df93be813c7fdf1626a06df14ff9b7585655fd
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/4948/1
--
To view, visit http://gerrit.cloudera.org:8080/4948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3df93be813c7fdf1626a06df14ff9b7585655fd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
......................................................................
[java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
We were logging the RPC after calling errback on it, so some of the fields were
already nulled out. Mostly a cosmetic change, for a DEBUG log line.
Change-Id: If3df93be813c7fdf1626a06df14ff9b7585655fd
Reviewed-on: http://gerrit.cloudera.org:8080/4948
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If3df93be813c7fdf1626a06df14ff9b7585655fd
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java client] Small fix to logging in AsyncKuduClient.tooManyAttemptsOrTimeout
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4948
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3df93be813c7fdf1626a06df14ff9b7585655fd
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No